Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_copy_response_code_to_downstream_stream_info deprecation #33615

Closed
adisuissa opened this issue Apr 17, 2024 · 0 comments · Fixed by #33639
Closed

envoy_reloadable_features_copy_response_code_to_downstream_stream_info deprecation #33615

adisuissa opened this issue Apr 17, 2024 · 0 comments · Fixed by #33639
Assignees
@jbohanon
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@adisuissa
Copy link
Contributor

Your change #29028 (router: add response_code to downstream stream_info) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbohanon jbohanon

Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove runtime guard copy_response_code_to_downstream_stream_info jbohanon/envoy
2 participants
@adisuissa @jbohanon