Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: support ALPN (HTTP/1.1 HTTP/2 negotiation) #502

Open
rebello95 opened this issue Oct 14, 2019 · 0 comments
Open

core: support ALPN (HTTP/1.1 HTTP/2 negotiation) #502

rebello95 opened this issue Oct 14, 2019 · 0 comments
Labels
core fallbacks help wanted no stalebot
Milestone
Backlog

Comments

@rebello95
Copy link
Contributor

As of #417, Envoy Mobile defaults traffic to HTTP/2. Depending on the server being communicated with, however, this can potentially cause problems with ALPN if the upstream server doesn't support HTTP/2. To resolve this, Envoy Mobile should be capable of doing this negotiation between HTTP/1.1 and HTTP/2.

There's an upstream issue in Envoy tracking adding support for this: envoyproxy/envoy#3431.

Once support is added, the demo apps / liveliness CI tests should be updated to test both HTTP/1.1 and HTTP/2.
@rebello95 rebello95 mentioned this issue Oct 14, 2019
Merged
rebello95 added a commit that referenced this issue Oct 14, 2019
@rebello95
config: enable HTTP/2 (#417)
604dbbc 
Updates the standard configuration to send requests over HTTP/2 by default.

Note that there are future improvements that should be made here to support negotiating between HTTP/1.1 and HTTP/2, being tracked in #502.

More info on the config change: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cds.proto#envoy-api-msg-cluster

Signed-off-by: Michael Rebello <[email protected]>
@buildbreaker buildbreaker mentioned this issue Oct 15, 2019
Merged
buildbreaker pushed a commit that referenced this issue Oct 17, 2019
kotlin: grpc codec (#472)
1982e78 
gRPC codec for kotlin

We are able to hit an Envoy backed gRPC server from `lyft.com`

We ran into some issues with testing (debug pull: #495). The first is outgoing ALPN is required for gRPC connections: #502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future.

For now, we are primarily missing #494 for local Envoy library e2e testing

Signed-off-by: Alan Chiu <[email protected]>

Description: gRPC codec for kotlin
Risk Level: low
Testing: unit/end-to-end
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]
@buildbreaker buildbreaker mentioned this issue Oct 30, 2019
Merged
buildbreaker pushed a commit that referenced this issue Oct 30, 2019
kotlin: remove tests for grpc (#560)
07de972 
Removing E2E gRPC testing infrastructure since we are unable to communicate with a vanilla gRPC service due to: #502

Signed-off-by: Alan Chiu <[email protected]>

Description: remove unused tests for grpc and protos
Risk Level: low
Testing: none
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]
@junr03 junr03 mentioned this issue Feb 11, 2020
Closed
@junr03 junr03 mentioned this issue Feb 21, 2020
Merged
junr03 added a commit that referenced this issue Feb 21, 2020
@junr03 @rebello95
upsteam protocol: add the ability to decide what protocol to use for …
92f9bf2 
…upstream requests (#697)

Description: this PR adds the ability to decide what protocol to use for upstream requests. Note that this will be unnecessary once ALPN works for upstream requests (#502)
Risk Level: low
Testing: updated unit tests
Docs Changes: updated docs

Fixes #679 

Signed-off-by: Michael Rebello <[email protected]>

Co-authored-by: Michael Rebello <[email protected]>
@junr03 junr03 added this to the Backlog milestone Mar 19, 2020
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@rebello95 @jpsim
config: enable HTTP/2 (#417)
a7637b1 
Updates the standard configuration to send requests over HTTP/2 by default.

Note that there are future improvements that should be made here to support negotiating between HTTP/1.1 and HTTP/2, being tracked in envoyproxy/envoy-mobile#502.

More info on the config change: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cds.proto#envoy-api-msg-cluster

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@jpsim
kotlin: grpc codec (#472)
5e96a17 
gRPC codec for kotlin

We are able to hit an Envoy backed gRPC server from `lyft.com`

We ran into some issues with testing (debug pull: envoyproxy/envoy-mobile#495). The first is outgoing ALPN is required for gRPC connections: envoyproxy/envoy-mobile#502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future.

For now, we are primarily missing envoyproxy/envoy-mobile#494 for local Envoy library e2e testing

Signed-off-by: Alan Chiu <[email protected]>

Description: gRPC codec for kotlin
Risk Level: low
Testing: unit/end-to-end
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@jpsim
kotlin: remove tests for grpc (#560)
09627be 
Removing E2E gRPC testing infrastructure since we are unable to communicate with a vanilla gRPC service due to: envoyproxy/envoy-mobile#502

Signed-off-by: Alan Chiu <[email protected]>

Description: remove unused tests for grpc and protos
Risk Level: low
Testing: none
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 28, 2022
@junr03 @rebello95 @jpsim
upsteam protocol: add the ability to decide what protocol to use for …
c1601d6 
…upstream requests (#697)

Description: this PR adds the ability to decide what protocol to use for upstream requests. Note that this will be unnecessary once ALPN works for upstream requests (envoyproxy/envoy-mobile#502)
Risk Level: low
Testing: updated unit tests
Docs Changes: updated docs

Fixes #679

Signed-off-by: Michael Rebello <[email protected]>

Co-authored-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@rebello95 @jpsim
config: enable HTTP/2 (#417)
29333fd 
Updates the standard configuration to send requests over HTTP/2 by default.

Note that there are future improvements that should be made here to support negotiating between HTTP/1.1 and HTTP/2, being tracked in envoyproxy/envoy-mobile#502.

More info on the config change: https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cds.proto#envoy-api-msg-cluster

Signed-off-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@jpsim
kotlin: grpc codec (#472)
90dfbaf 
gRPC codec for kotlin

We are able to hit an Envoy backed gRPC server from `lyft.com`

We ran into some issues with testing (debug pull: envoyproxy/envoy-mobile#495). The first is outgoing ALPN is required for gRPC connections: envoyproxy/envoy-mobile#502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future.

For now, we are primarily missing envoyproxy/envoy-mobile#494 for local Envoy library e2e testing

Signed-off-by: Alan Chiu <[email protected]>

Description: gRPC codec for kotlin
Risk Level: low
Testing: unit/end-to-end
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@jpsim
kotlin: remove tests for grpc (#560)
45b3f8f 
Removing E2E gRPC testing infrastructure since we are unable to communicate with a vanilla gRPC service due to: envoyproxy/envoy-mobile#502

Signed-off-by: Alan Chiu <[email protected]>

Description: remove unused tests for grpc and protos
Risk Level: low
Testing: none
Docs Changes: n/a
Release Notes: n/a
[Optional Fixes #Issue]
[Optional Deprecated:]

Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit to envoyproxy/envoy that referenced this issue Nov 29, 2022
@junr03 @rebello95 @jpsim
upsteam protocol: add the ability to decide what protocol to use for …
31f409b 
…upstream requests (#697)

Description: this PR adds the ability to decide what protocol to use for upstream requests. Note that this will be unnecessary once ALPN works for upstream requests (envoyproxy/envoy-mobile#502)
Risk Level: low
Testing: updated unit tests
Docs Changes: updated docs

Fixes #679

Signed-off-by: Michael Rebello <[email protected]>

Co-authored-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core fallbacks help wanted no stalebot
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@rebello95 @junr03