Fix dynamic cluster immediate resolution initialization bugs. #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ensure that the cluster initialization callback is invoked immediately if initialization has already been complete when it is set. * Don't invoke startResolve() for LogicalDnsCluster until we have the required TLS initialized. * Initialize StrictDnsClusterImpl resolve_targets_ before starting DNS resolution, since the resolve callback iterates over this. * Various unit tests and modified the H2 integration test to also cover logical_dns.
| @@ -182,6 +182,9 @@ ClusterManagerImpl::ClusterManagerImpl(const Json::Object& config, ClusterManage | |||
|
|
|||
| // To avoid threading issues, for those clusters that start with hosts already in them (like | |||
| // the static cluster), we need to post an update onto each thread to notify them of the update. | |||
| // We also require this for dynamic clusters where an immediate resolve | |||
There was a problem hiding this comment.
nit: Can you flow this comment out to 100 or reflow the entire thing to 80. It just looks strange.
mattklein123
approved these changes
Feb 13, 2017
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
* zh-traslation:docs/root/start/sandboxes/csrf.rst * fix translation issue
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
gRPC codec for kotlin We are able to hit an Envoy backed gRPC server from `lyft.com` We ran into some issues with testing (debug pull: envoyproxy/envoy-mobile#495). The first is outgoing ALPN is required for gRPC connections: envoyproxy/envoy-mobile#502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future. For now, we are primarily missing envoyproxy/envoy-mobile#494 for local Envoy library e2e testing Signed-off-by: Alan Chiu <[email protected]> Description: gRPC codec for kotlin Risk Level: low Testing: unit/end-to-end Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <[email protected]>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
gRPC codec for kotlin We are able to hit an Envoy backed gRPC server from `lyft.com` We ran into some issues with testing (debug pull: envoyproxy/envoy-mobile#495). The first is outgoing ALPN is required for gRPC connections: envoyproxy/envoy-mobile#502. gRPC doesn't support disabling this option when starting up a service. We'll have to revisit this effort in the future. For now, we are primarily missing envoyproxy/envoy-mobile#494 for local Envoy library e2e testing Signed-off-by: Alan Chiu <[email protected]> Description: gRPC codec for kotlin Risk Level: low Testing: unit/end-to-end Docs Changes: n/a Release Notes: n/a [Optional Fixes #Issue] [Optional Deprecated:] Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the cluster initialization callback is invoked immediately
if initialization has already been complete when it is set.
Don't invoke startResolve() for LogicalDnsCluster until we have the
required TLS initialized.
Initialize StrictDnsClusterImpl resolve_targets_ before starting DNS
resolution, since the resolve callback iterates over this.
Various unit tests and modified the H2 integration test to also cover logical_dns.