Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add set -e on recipe scripts #697

Merged
merged 1 commit into from
Apr 4, 2017
Merged

build: add set -e on recipe scripts #697

merged 1 commit into from
Apr 4, 2017

Conversation

mattklein123
Copy link
Member

No description provided.

@mattklein123
Copy link
Member Author

@htuch

Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattklein123 mattklein123 merged commit 4cf8465 into master Apr 4, 2017
@mattklein123 mattklein123 deleted the build_errors branch April 4, 2017 22:56
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
jpsim pushed a commit that referenced this pull request Nov 28, 2022
…upstream requests (#697)

Description: this PR adds the ability to decide what protocol to use for upstream requests. Note that this will be unnecessary once ALPN works for upstream requests (envoyproxy/envoy-mobile#502)
Risk Level: low
Testing: updated unit tests
Docs Changes: updated docs

Fixes #679

Signed-off-by: Michael Rebello <[email protected]>

Co-authored-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
…upstream requests (#697)

Description: this PR adds the ability to decide what protocol to use for upstream requests. Note that this will be unnecessary once ALPN works for upstream requests (envoyproxy/envoy-mobile#502)
Risk Level: low
Testing: updated unit tests
Docs Changes: updated docs

Fixes #679

Signed-off-by: Michael Rebello <[email protected]>

Co-authored-by: Michael Rebello <[email protected]>
Signed-off-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants