-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Google Analytics 4 (GA4) #2680
Comments
From @jpsim:
I'm not familiar with that extension so I don't know if it supports GA4. We can give it a try :). |
Giving it a try here: #2681 |
I'm not seeing any GA4 ID in the site pages, are you @jpsim? If not, can you re-open this issue :)? |
Oh ... now that I've caught up with your comment in the Jira ticket, I see that what you've done is enabled GA over the doc pages. I was looking at the main site. Can you reopen this issue so that we can use it to track the addition of GA to the main site too? |
Since you have access to the analytics dashboard, can you check if you see traffic from the EM docs site which was deployed about an hour ago? Like on this page? https://envoymobile.io/docs/envoy-mobile/latest/index.html |
AFAIK, the GA4 console doesn't, at the moment, have as good realtime traffic data as UA does, so I can't tell if there's traffic from the EM docs site yet. Usually, I test pages in true realtime using the Google Tag Assistant, but it is refusing to connect to the site, apparently because the homepage doesn't have a GA ID. @jpsim - can you add the GA4 ID to all of the main (non-docs) site pages? Then I'll be able to use the tag assistant. |
Ok @chalin, I just updated the only other non-doc page in envoy-mobile/envoy-mobile.github.io#27 |
Seems to be hooked up correctly on the website side of things. Here's the network activity when loading https://envoymobile.io before and after envoy-mobile/envoy-mobile.github.io#27: BeforeAfter |
From the analytics console I'm seeing traffic only from the landing page: Your "after" network screenshot above confirms that the |
I see that the So maybe it's a question of fetching the latest version? |
Here is what I used on another project:
|
We require tagged releases for our Python dependencies. Here's what I get when I point to the latest commit:
I've requested a tagged release in sphinx-contrib/googleanalytics#5 |
Updating in #2708 |
* Use the same as the envoy proxy and envoy mobile websites Relates to envoyproxy/envoy-website#273 & envoyproxy/envoy-mobile#2680 Signed-off-by: Arko Dasgupta <[email protected]>
* Use the same as the envoy proxy and envoy mobile websites Relates to envoyproxy/envoy-website#273 & envoyproxy/envoy-mobile#2680 Signed-off-by: Arko Dasgupta <[email protected]>
* Use the same as the envoy proxy and envoy mobile websites Relates to envoyproxy/envoy-website#273 & envoyproxy/envoy-mobile#2680 Signed-off-by: Arko Dasgupta <[email protected]>
* Use the same as the envoy proxy and envoy mobile websites Relates to envoyproxy/envoy-website#273 & envoyproxy/envoy-mobile#2680 Signed-off-by: Arko Dasgupta <[email protected]>
As discussed elsewhere (https://cncfservicedesk.atlassian.net/browse/CNCFSD-1458), the plan is to enable GA4 by using the existing GA4 Envoy web data stream with ID
G-DXJEH1ZRXX
.For some context, the main repo was migrated to GA4 via:
Let's use this issue to discuss implementation details.
Tasks:
Add Google Analytics to
index.html
envoy-mobile/envoy-mobile.github.io#27The text was updated successfully, but these errors were encountered: