Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update sphinxcontrib-googleanalytics #2708

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Nov 29, 2022

Description: docs: update sphinxcontrib-googleanalytics
Risk Level: Low, could break the site but not the library
Testing: Local via Docker
Docs Changes: Adds analytics to docs
Release Notes: None
Fixes: #2680

Signed-off-by: JP Simard [email protected]

@jpsim jpsim marked this pull request as ready for review November 29, 2022 00:28
@jpsim jpsim mentioned this pull request Nov 29, 2022
2 tasks
@jpsim jpsim requested a review from Augustyniak November 29, 2022 01:19
Copy link
Contributor

@Augustyniak Augustyniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls clean-up/update description of the PR

@jpsim jpsim merged commit 45ff331 into main Nov 29, 2022
@jpsim jpsim deleted the docs-update-sphinxcontrib-googleanalytics branch November 29, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Google Analytics 4 (GA4)
2 participants