Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Set GA4 ID #4919

Merged
merged 1 commit into from
Dec 16, 2024
Merged

docs: Set GA4 ID #4919

merged 1 commit into from
Dec 16, 2024

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Dec 13, 2024

  • Use the same as the envoy proxy and envoy mobile websites

Relates to envoyproxy/envoy-website#273 & envoyproxy/envoy-mobile#2680

* Use the same as the envoy proxy and envoy mobile websites

Relates to envoyproxy/envoy-website#273 & envoyproxy/envoy-mobile#2680

Signed-off-by: Arko Dasgupta <[email protected]>
@arkodg arkodg requested a review from a team as a code owner December 13, 2024 04:35
@arkodg
Copy link
Contributor Author

arkodg commented Dec 13, 2024

cc @phlax

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.28%. Comparing base (685c5dd) to head (1abc06d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4919      +/-   ##
==========================================
+ Coverage   66.27%   66.28%   +0.01%     
==========================================
  Files         209      209              
  Lines       31922    31942      +20     
==========================================
+ Hits        21156    21174      +18     
+ Misses       9518     9516       -2     
- Partials     1248     1252       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arkodg arkodg requested review from a team December 13, 2024 18:36
@arkodg arkodg merged commit 67bf63c into envoyproxy:main Dec 16, 2024
27 checks passed
@arkodg arkodg deleted the ga4 branch December 16, 2024 15:42
Dean-Coakley pushed a commit to Dean-Coakley/envoy-gateway that referenced this pull request Dec 20, 2024
* Use the same as the envoy proxy and envoy mobile websites

Relates to envoyproxy/envoy-website#273 & envoyproxy/envoy-mobile#2680

Signed-off-by: Arko Dasgupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants