Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: is not reporting failure #1009

Closed
junr03 opened this issue Aug 7, 2020 · 0 comments · Fixed by #1014
Closed

coverage: is not reporting failure #1009

junr03 opened this issue Aug 7, 2020 · 0 comments · Fixed by #1014
Assignees
@junr03
Labels
area/testing issues for improving testing of the library no stalebot

Comments

@junr03
Copy link
Member

junr03 commented Aug 7, 2020

I realized after digging into coverage after #940 that the coverage CI job was not reporting failure. The environment was missing lcov, so while coverage tests were run the report was not being generated. This should be fixed and re-enabled.
@junr03 junr03 self-assigned this Aug 7, 2020
@junr03 junr03 added area/testing issues for improving testing of the library no stalebot labels Aug 7, 2020
This was referenced Aug 7, 2020
Closed
Merged
junr03 added a commit that referenced this issue Aug 10, 2020
@junr03
coverage: disable until OOM is solved (#1011)
a543625 
Description: deleting until OOM is fixed.
Risk Level: med - no coverage run. Although it was already broken per #1009

Signed-off-by: Jose Nino <[email protected]>
@junr03 junr03 mentioned this issue Aug 10, 2020
Merged
junr03 added a commit that referenced this issue Sep 24, 2020
@junr03
ci: update to clang 10 and install lcov (#1014)
50d91e0 
Description: update clang, install lcov, and bring back coverage for CI.
Risk Level: low
Testing: CI

Fixes #1009 #1012

Signed-off-by: Jose Nino <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junr03 junr03

Labels
area/testing issues for improving testing of the library no stalebot
Projects
None yet
Milestone
No milestone
1 participant
@junr03