Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage: upload report #999

Closed
wants to merge 5 commits into from
Closed

coverage: upload report #999

wants to merge 5 commits into from

Conversation

junr03
Copy link
Member

@junr03 junr03 commented Aug 3, 2020

Description: installs lcov in order to generate coverage reports once again.
Fixes #1009

Signed-off-by: Jose Nino [email protected]

Signed-off-by: Jose Nino <[email protected]>
@junr03
Copy link
Member Author

junr03 commented Aug 3, 2020

@goaway I am not sure why the coverage test is still passing. I realized that after merging all the platform_bridge code coverage should have dropped. My local coverage run is failing with:

Overall coverage rate:
  lines......: 79.9% (650 of 814 lines)
  functions..: 68.6% (70 of 102 functions)
Code coverage 79.9 is lower than limit of 96.5

as I would expect. This PR should let us see what is going on with the coverage run in CI

@junr03
Copy link
Member Author

junr03 commented Aug 3, 2020

@goaway relatedly, I know the main way you want to test the platform bridge filter is with #995. But I think we can also write a unit test suite with simple c++ implementation of a "platform" api.

Signed-off-by: Jose Nino <[email protected]>
@junr03
Copy link
Member Author

junr03 commented Aug 3, 2020

Jose Nino added 3 commits August 3, 2020 16:55
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
@junr03
Copy link
Member Author

junr03 commented Aug 4, 2020

@goaway ok now I see in CI what I see locally as well: https://github.com/lyft/envoy-mobile/pull/999/checks?check_run_id=942878705#step:4:1028.

Do you mind writing tests to improve coverage?

@junr03
Copy link
Member Author

junr03 commented Aug 7, 2020

Blocked by #1008

@junr03
Copy link
Member Author

junr03 commented Aug 10, 2020

fixed in #1014

@junr03 junr03 closed this Aug 10, 2020
@junr03 junr03 deleted the coverage branch July 20, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coverage: is not reporting failure
1 participant