ci: update to clang 10 and install lcov #1014
Conversation
This reverts commit a543625. Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| # Checks the absolute size and the relative size increase of a file. | |||
|
|
|||
| MAX_SIZE=5900000 # 5.9MB | |||
| MAX_SIZE=6000000 # 6MB | |||
There was a problem hiding this comment.
Why is this increasing in this PR?
There was a problem hiding this comment.
I am guessing compilation differences between clang 8 and clang 10? Not entirely sure. We need to run the size analysis again.
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
Signed-off-by: Jose Nino <[email protected]>
|
@rebello95 @buildbreaker @goaway this is done, can I get another review? |
.github/workflows/coverage.yml
Outdated
| # - 'library/common/**' | ||
| # - 'test/**' |
There was a problem hiding this comment.
Do these still need to be here?
Signed-off-by: Jose Nino <[email protected]>
|
@rebello95 updated! |
Description: update clang, install lcov, and bring back coverage for CI.
Risk Level: low
Testing: CI
Fixes #1009 #1012
Signed-off-by: Jose Nino [email protected]