This repository has been archived by the owner on Dec 28, 2021. It is now read-only.
Deselect visualization when its node gets removed #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s9ferech
added
Category: GUI
s9ferech
changed the title
To make sure that the node id is still valid
wdanilo
suggested changes
May 10, 2021
| @@ -1403,6 +1403,7 @@ impl GraphEditorModel { | |||
| /// implementation. | |||
| fn remove_node(&self, node_id:impl Into<NodeId>) { | |||
| let node_id = node_id.into(); | |||
| self.frp.source.on_visualization_select.emit(Switch::Off(node_id)); | |||
There was a problem hiding this comment.
Emiting frp events from model functions is rather a bad pattern, as it is really hard to understand where the events come from. Instead, check where this model function is called in the FRP network and handle it directly there.
This should be handled next to the lines:
output.source.on_visualization_select <+ selected.constant(Switch::On(node_id));
output.source.on_visualization_select <+ deselected.constant(Switch::Off(node_id));
so it would be easy to track when visualization is deselectected when reading the code (all deselecting will be coded in one place then)
There was a problem hiding this comment.
I changed this, but it cannot be handled next to the lines that you suggested, because we need only one connection per graph editor, but those lines are run for every node.
wdanilo
approved these changes
May 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This fixes issue #1352. The graph editor will register visualizations as deselected when their node is removed.
Important Notes
Checklist
Please include the following checklist in your PR:
CHANGELOG.mdwas updated with the changes introduced in this PR.