Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Deselect visualization when its node gets removed #1556

Merged
merged 8 commits into from
May 13, 2021
+5 −0
Merged

Deselect visualization when its node gets removed #1556

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2553234
Deselect visualization when the node gets removed
s9ferech May 7, 2021
d668c7d
Merge branch 'develop' of https://github.com/enso-org/ide into develop
s9ferech May 7, 2021
db7225e
Update CHANGELOG.md
s9ferech May 7, 2021
7a3d992
Fix formatting of CHANGELOG.md
s9ferech May 7, 2021
5c42ee1
Deselect visualization before the node gets removed
s9ferech May 7, 2021
a7ee9fe
Follow review comments
s9ferech May 10, 2021
fc1f58c
Merge branch 'develop' into deselect-visualization
s9ferech May 10, 2021
5e6362a
Merge branch 'develop' into deselect-visualization
s9ferech May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
#### Visual Environment

- [Delete key will delete selected nodes][1538].
- [It is possible to move around after deleting a selected visualization][1556].
s9ferech marked this conversation as resolved.
Show resolved Hide resolved

#### EnsoGL (rendering engine)

Expand Down
1 change: 1 addition & 0 deletions src/rust/ide/view/graph-editor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1403,6 +1403,7 @@ impl GraphEditorModel {
/// implementation.
fn remove_node(&self, node_id:impl Into<NodeId>) {
let node_id = node_id.into();
self.frp.source.on_visualization_select.emit(Switch::Off(node_id));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emiting frp events from model functions is rather a bad pattern, as it is really hard to understand where the events come from. Instead, check where this model function is called in the FRP network and handle it directly there.

This should be handled next to the lines:

output.source.on_visualization_select <+ selected.constant(Switch::On(node_id));
output.source.on_visualization_select <+ deselected.constant(Switch::Off(node_id));

so it would be easy to track when visualization is deselectected when reading the code (all deselecting will be coded in one place then)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this, but it cannot be handled next to the lines that you suggested, because we need only one connection per graph editor, but those lines are run for every node.

self.nodes.remove(&node_id);
self.nodes.selected.remove_item(&node_id);
}
Expand Down