Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Commit

Permalink
Deselect visualization when its node gets removed (#1556)
Browse files Browse the repository at this point in the history
  • Loading branch information
s9ferech authored May 13, 2021
1 parent 9d8c2fd commit f9778d6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
#### Visual Environment

- [Delete key will delete selected nodes][1538].
- [It is possible to move around after deleting a node with a selected
visualization][1556]. Deleting a node while its attached visualization was
selected made it impossible to pan or zoom around the stage afterwards. This
error is fixed now.
- [Fixed an internal error that would make the IDE fail on some browser.][1561].
Instead of crashing on browser that don't support the feature we use, we are
now just start a little bit slower.
Expand Down
1 change: 1 addition & 0 deletions src/rust/ide/view/graph-editor/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2987,6 +2987,7 @@ fn new_graph_editor(app:&Application) -> GraphEditor {
eval out.node_selected ((id) model.select_node(id));
eval out.node_deselected ((id) model.deselect_node(id));
eval out.node_removed ((id) model.remove_node(id));
out.source.on_visualization_select <+ out.node_removed.map(|&id| Switch::Off(id));

eval inputs.set_node_expression (((id,expr)) model.set_node_expression(id,expr));
port_to_refresh <= inputs.set_node_expression.map(f!(((id,_))model.node_in_edges(id)));
Expand Down

0 comments on commit f9778d6

Please sign in to comment.