Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inhibit clipping when dropdown is opened #9434

Merged
merged 4 commits into from
Mar 17, 2024
Merged

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Mar 14, 2024

Pull Request Description

Fixes #9379.

Important Notes

  • The existence-registry could be implemented with a counter, but a set is more debuggable and the performance cost is negligible.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@kazcw kazcw added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels Mar 14, 2024
@kazcw kazcw self-assigned this Mar 14, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 14, 2024

Keziah Wesley reports a new STANDUP for today (2024-03-14):

Progress: Fixed dropdown clipping. Implemented conditional ports. It should be finished by 2024-03-15.

Next Day: Next day I will be working on the #9434 task. Start on multiselect

app/gui2/src/components/widgets/DropdownWidget.vue Outdated Show resolved Hide resolved
app/gui2/src/providers/widgetTree.ts Show resolved Hide resolved
Comment on lines +51 to +54
<div
v-if="tree.extended || !application.argument.hideByDefault"
class="argument overridableClipState"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it the only place which may clip drop-down? Could node clip the leftmost drop-down?

Copy link
Contributor Author

@kazcw kazcw Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents the clipping required by the hidden-placeholders animation from interfering with the dropdown. I don't think we have any other animations that could clip the dropdown, but if we do this solution could be applied to them. If any widget is enabling clipping on its children statically, that would be a separate problem with a different solution (the widget must not do that).

@farmaazon
Copy link
Contributor

And one more thing: please add documentation explaining why do we have those clipping inhibitors.

@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Mar 15, 2024
@mergify mergify bot merged commit babf4eb into develop Mar 17, 2024
41 checks passed
@mergify mergify bot deleted the wip/kw/clipping-inhibition branch March 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown width is truncated.
2 participants