-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inhibit clipping when dropdown is opened #9434
Conversation
Keziah Wesley reports a new STANDUP for today (2024-03-14): Progress: Fixed dropdown clipping. Implemented conditional ports. It should be finished by 2024-03-15. Next Day: Next day I will be working on the #9434 task. Start on multiselect |
<div | ||
v-if="tree.extended || !application.argument.hideByDefault" | ||
class="argument overridableClipState" | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the only place which may clip drop-down? Could node clip the leftmost drop-down?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This prevents the clipping required by the hidden-placeholders animation from interfering with the dropdown. I don't think we have any other animations that could clip the dropdown, but if we do this solution could be applied to them. If any widget is enabling clipping on its children statically, that would be a separate problem with a different solution (the widget must not do that).
And one more thing: please add documentation explaining why do we have those clipping inhibitors. |
Pull Request Description
Fixes #9379.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.