Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown width is truncated. #9379

Closed
Tracked by #9354
farmaazon opened this issue Mar 12, 2024 · 5 comments · Fixed by #9384 or #9434
Closed
Tracked by #9354

Dropdown width is truncated. #9379

farmaazon opened this issue Mar 12, 2024 · 5 comments · Fixed by #9384 or #9434
Assignees
@kazcw
Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Mar 12, 2024 •
edited
Loading

No description provided.

@farmaazon farmaazon mentioned this issue Mar 12, 2024
Closed
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint -gui --bug Type: bug labels Mar 12, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Mar 12, 2024
@kazcw kazcw self-assigned this Mar 12, 2024
@kazcw kazcw moved this from 📤 Backlog to 🔧 Implementation in Issues Board Mar 12, 2024
@jdunkerley
Copy link
Member

Better screenshot of truncation issue:
image

@farmaazon
Copy link
Contributor Author

farmaazon commented Mar 12, 2024 •
edited
Loading

I just pasted the wrong link.

@kazcw kazcw mentioned this issue Mar 12, 2024
Merged
5 tasks
@mergify mergify bot closed this as completed in #9384 Mar 12, 2024
mergify bot pushed a commit that referenced this issue Mar 12, 2024
@kazcw
Fix dropdown clipping (#9384)
64e29f8 
Fixes #9379.
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Mar 12, 2024
@enso-bot
Copy link

enso-bot bot commented Mar 12, 2024

Keziah Wesley reports a new STANDUP for today (2024-03-12):

Progress: Fixed dropdown clipping. Started on visualizations creating components. It should be finished by 2024-03-12.

Next Day: Next day I will be working on the #9226 task. Work on JSON visualization.

@jdunkerley jdunkerley reopened this Mar 13, 2024
@github-project-automation github-project-automation bot moved this from 🟢 Accepted to ❓New in Issues Board Mar 13, 2024
@jdunkerley
Copy link
Member

Sorry this still seems to be an issue.

@kazcw
Copy link
Contributor

kazcw commented Mar 13, 2024 •
edited
Loading

Looked in to this: The type of animation we're using for hidden arguments is essentially incompatible with our current DOM structure. We could fix it by teleporting the dropdown to not be a descendant of the WidgetArgument; that is not trivial to do. For now we will have to disable the animation.

@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Mar 14, 2024
@kazcw kazcw moved this from 📤 Backlog to 👁️ Code review in Issues Board Mar 14, 2024
@kazcw kazcw mentioned this issue Mar 14, 2024
Merged
5 tasks
@farmaazon farmaazon mentioned this issue Mar 15, 2024
Closed
@kazcw kazcw moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 15, 2024
@mergify mergify bot closed this as completed in #9434 Mar 17, 2024
mergify bot pushed a commit that referenced this issue Mar 17, 2024
@kazcw
Inhibit clipping when dropdown is opened (#9434)
babf4eb 
Fixes #9379.

# Important Notes
- The existence-registry could be implemented with a counter, but a set is more debuggable and the performance cost is negligible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dropdown clipping enso-org/enso
Inhibit clipping when dropdown is opened enso-org/enso
3 participants
@kazcw @farmaazon @jdunkerley