Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download single edition by name #7771

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Sep 8, 2023

Pull Request Description

close #7480

Changelog:

  • update: download the single required edition instead of batch update

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 8, 2023
@4e6 4e6 self-assigned this Sep 8, 2023
@4e6
Copy link
Contributor Author

4e6 commented Sep 11, 2023

QA:

  • Clean the ENSO_DATA_DIRECTORY directory
  • Build IDE with ./run ide build or download one from the CI, i.e. commit 0afb206
  • Open a new project or change the edition of the existing project, for example to 2023.2.1-nightly.2023.9.7

@JaroslavTulach
Copy link
Member

Shouldn't we avoid downloading anything (including an edition) when one downloads IDE and creates new project? Everything shall be ready locally (GraalVM, engine, stdlibs, edition).

@hubertp
Copy link
Collaborator

hubertp commented Sep 12, 2023

Shouldn't we avoid downloading anything (including an edition) when one downloads IDE and creates new project? Everything shall be ready locally (GraalVM, engine, stdlibs, edition).

There is a separate ticket for that #7698.

@hubertp
Copy link
Collaborator

hubertp commented Sep 12, 2023

I'm still seeing

[DEBUG] [2023-09-12T10:27:56+02:00] [org.enso.projectmanager.requesthandler.ProjectListHandler] started (org.enso.projectmanager.requesthandler.ProjectListHandler@341bbd41)
[DEBUG] [2023-09-12T10:27:56+02:00] [org.enso.downloader.http.HTTPDownload] Fetching [https://editions.release.enso.org/enso/manifest.yaml].
[WARN] [2023-09-12T10:27:56+02:00] [org.enso.projectmanager.service.ProjectService] Could not resolve engine version for Edition(Some(2023.2.1-nightly.2023.8.15),None,Map(),Map()). Falling back to Edition(Some(0.0.0-dev),None,Map(),Map())
[DEBUG] [2023-09-12T10:27:56+02:00] [org.enso.downloader.http.HTTPDownload] Fetching [https://editions.release.enso.org/enso/manifest.yaml].

when I deleted the specific version and opening a different version project. Shouldn't these be gone as well?

@4e6
Copy link
Contributor Author

4e6 commented Sep 12, 2023

when I deleted the specific version and opening a different version project. Shouldn't these be gone as well?

@hubertp it makes sense to fallback to default edition because there's no 2023.2.1-nightly.2023.8.15 version published https://editions.release.enso.org/enso/manifest.yaml

@hubertp
Copy link
Collaborator

hubertp commented Sep 15, 2023

when I deleted the specific version and opening a different version project. Shouldn't these be gone as well?

@hubertp it makes sense to fallback to default edition because there's no 2023.2.1-nightly.2023.8.15 version published https://editions.release.enso.org/enso/manifest.yaml

Yes, but why does it check it all? I'm not opening that project.

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Sep 18, 2023
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a separate ticket for the discovered problem.

@mergify mergify bot merged commit 42a8567 into develop Sep 18, 2023
1 check passed
@mergify mergify bot deleted the wip/db/7480-creating-a-project-on-a-new-machine-for-the-first-time-takes-ages branch September 18, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a project on a new machine for the first time takes ages and eventually hangs infinitely
3 participants