Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage cannot be used expanded: tries to download GraalVM #7698

Closed
JaroslavTulach opened this issue Aug 30, 2023 · 3 comments · Fixed by #7948
Closed

AppImage cannot be used expanded: tries to download GraalVM #7698

JaroslavTulach opened this issue Aug 30, 2023 · 3 comments · Fixed by #7948
Assignees

Comments

@JaroslavTulach
Copy link
Member

Trying to investigate the behavior behind proxy

I contacted a friend behind a corporate proxy and asked him to use https://github.com/enso-org/enso/releases/tag/2023.2.1-nightly.2023.8.29. He downloaded AppImage and tried to use it on his Ubuntu. He doesn't have FUSE installed, so the AppImage told him to extract itself. After doing so, starting ./AppRun and creating the new project, everything stopped because GraalVM runtime [GraalVM 23.0.0 Java 17.0.7] not found. But the runtime is part of the AppImage!

[info] [2023-08-30T10:59:14.019Z] [org.enso.projectmanager.boot.ProjectManager$] Starting Enso Project Manager
Version:    2023.2.1-nightly.2023.8.29
Built with: scala-2.13.11 for GraalVM 17.0.7
Built from: develop* @ e0ef0a258d82dc06caac443c0af308bc9807c866
Built on:   Linux (amd64)

[info] [2023-08-30T10:59:14.034Z] [org.enso.projectmanager.boot.ProjectManager$] Started server at 127.0.0.1:30535, press enter to kill server
[info] [2023-08-30T10:59:18.301Z] [org.enso.projectmanager.protocol.ClientController] Client connected to Project Manager [98f317e1-ec23-49d5-8b94-3891559fac5e]
[info] [2023-08-30T10:59:21.515Z] [org.enso.projectmanager.infrastructure.log.Slf4jLogging] Created project with actual name [New_Project_1].
[info] [2023-08-30T10:59:21.516Z] [org.enso.runtimeversionmanager.components.RuntimeVersionManager] The engine [2023.2.1-nightly.2023.8.29] found.
[info] [2023-08-30T10:59:21.516Z] [org.enso.runtimeversionmanager.components.RuntimeVersionManager] GraalVM runtime [GraalVM 23.0.0 Java 17.0.7] not found.
[info] [2023-08-30T10:59:21.517Z] [org.enso.runtimeversionmanager.components.RuntimeVersionManager] Installing GraalVM runtime [GraalVM 23.0.0 Java 17.0.7].
[warn] [2023-08-30T10:59:31.525Z] [org.enso.projectmanager.requesthandler.ProjectCreateHandler] Pending ProjectCreate response. Timeout retries left: 4.
[warn] [2023-08-30T10:59:41.545Z] [org.enso.projectmanager.requesthandler.ProjectCreateHandler] Pending ProjectCreate response. Timeout retries left: 3.
[warn] [2023-08-30T10:59:51.565Z] [org.enso.projectmanager.requesthandler.ProjectCreateHandler] Pending ProjectCreate response. Timeout retries left: 2.
[info] [2023-08-30T10:59:56.322Z] [org.enso.projectmanager.infrastructure.log.Slf4jLogging] Created project with actual name [Orders_1].
[info] [2023-08-30T10:59:56.323Z] [org.enso.runtimeversionmanager.components.RuntimeVersionManager] The engine [2023.2.1-nightly.2023.8.29] found.
[info] [2023-08-30T10:59:56.323Z] [org.enso.runtimeversionmanager.components.RuntimeVersionManager] GraalVM runtime [GraalVM 23.0.0 Java 17.0.7] not found.
[warn] [2023-08-30T11:00:01.585Z] [org.enso.projectmanager.requesthandler.ProjectCreateHandler] Pending ProjectCreate response. Timeout retries left: 1.
[warn] [2023-08-30T11:00:11.605Z] [org.enso.projectmanager.requesthandler.ProjectCreateHandler] Pending ProjectCreate response. Timeout retries left: 0

I'd say the error is in cooperation between org.enso.runtimeversionmanager.components.RuntimeVersionManager and the way AppImage is built.

@hubertp
Copy link
Collaborator

hubertp commented Sep 4, 2023

Likely caused by latest GraalVM upgrade and (now) broken links:

Should have more a format similar to graalvm-community-openjdk-17.0.7+7.1

@hubertp
Copy link
Collaborator

hubertp commented Sep 4, 2023

Actually, looks like locally we download and rename artifacts to fir the old format. But we don't do that when creating the AppImage. We should.

@hubertp
Copy link
Collaborator

hubertp commented Sep 4, 2023

@mwu-tow agreed to take over as this is very much in the build script/rust domain when we define bundles.

hubertp added a commit that referenced this issue Sep 4, 2023
While looking into #7698 discovered that the `buildGraalDistribution`
task would fail to use the old (pre-23.0) GraalVM naming of artifacts.
This has changed since #7176.

The fix does not attempt to fix a problem of packaged GraalVM name in
`runtime`. That, as the ticket mentiones it, is the role of rust build
script that creates the correct bundle.
hubertp added a commit that referenced this issue Sep 6, 2023
While looking into #7698 discovered that the `buildGraalDistribution`
task would fail to use the old (pre-23.0) GraalVM naming of artifacts.
This has changed since #7176.

The fix does not attempt to fix a problem of packaged GraalVM name in
`runtime`. That, as the ticket mentiones it, is the role of rust build
script that creates the correct bundle.
@jdunkerley jdunkerley moved this from 🔧 Implementation to 📤 Backlog in Issues Board Sep 26, 2023
@4e6 4e6 mentioned this issue Oct 2, 2023
3 tasks
@jdunkerley jdunkerley moved this from 📤 Backlog to 👁️ Code review in Issues Board Oct 3, 2023
@jdunkerley jdunkerley moved this from 👁️ Code review to 📤 Backlog in Issues Board Oct 3, 2023
@mergify mergify bot closed this as completed in #7948 Oct 6, 2023
mergify bot pushed a commit that referenced this issue Oct 6, 2023
close #7871
close #7698

Changelog:
- fix: the `run` script logic to place the GraalVM runtime in the expected directory when building the bundle
- fix: the `makeBundles` SBT logic to place the GraalVM runtime in the expected directory
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants