Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enso Engine bundle doesn't work without downloading #7871

Closed
JaroslavTulach opened this issue Sep 22, 2023 · 5 comments · Fixed by #7948
Closed

Enso Engine bundle doesn't work without downloading #7871

JaroslavTulach opened this issue Sep 22, 2023 · 5 comments · Fixed by #7948
Assignees

Comments

@JaroslavTulach
Copy link
Member

I've just downloaded latest nightly Enso engine bundle for Linux. When I try to use it:

enso$ ./bin/enso repl
Do you want to install the missing runtime? [Y/n]

it doesn't work and asks for download of something. That's wrong. The bundle shall work out of the box.

@JaroslavTulach JaroslavTulach changed the title Enso Engine bundle doesn't work without download Enso Engine bundle doesn't work without downloading Sep 23, 2023
@enso-bot enso-bot bot mentioned this issue Sep 23, 2023
4 tasks
@jdunkerley jdunkerley assigned 4e6 and unassigned mwu-tow and hubertp Sep 26, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Sep 26, 2023
@4e6 4e6 moved this from 📤 Backlog to 🔧 Implementation in Issues Board Sep 27, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 27, 2023

Dmitry Bushev reports a new STANDUP for yesterday (2023-09-26):

Progress: Was trying to fix the failing tests on CI. Introduced a new fake release. Tried to create a separate PR. Tried a clean build. Noticed that the clean step is not always triggered even if the appropriate tag exists. But even if the clean build is triggered, the CI fails anyway. It should be finished by 2023-10-02.

Next Day: Next day I will be working on the #7871 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Sep 27, 2023

Dmitry Bushev reports a new STANDUP for today (2023-09-27):

Progress: Started working on the issue. Built the IDE from develop and was able to reproduce the issue when the engine downloads an unknown release together with the runtime, even if the appropriate runtime is included in the bundle. Started to look into why the bundled runtime is not added to the search path. It should be finished by 2023-10-02.

Next Day: Next day I will be working on the #7871 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Sep 29, 2023

Dmitry Bushev reports a new STANDUP for yesterday (2023-09-28):

Progress: Temporarily switched to fixing the failing on CI PR. Found that the CI overrides the enso version, causing the new tests to fail. Updated the tests to override the enso version to a predefined one. Switched back to debugging the project manager bundle It should be finished by 2023-10-02.

Next Day: Next day I will be working on the #7871 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Sep 29, 2023

Dmitry Bushev reports a new STANDUP for today (2023-09-29):

Progress: Continue working on the issue. Confirmed that the bundle is built correctly and the packaged GraalVM is present on the search path. Found that the issue is because the GraalVM directory does not match the expected pattern. Discovered that the logic that creates the bundle is duplicated in SBT and Rust run script. The SBT one is not used. Both produce incorrect GraalVM directory name. It should be finished by 2023-10-02.

Next Day: Next day I will be working on the #7871 task. Continue working on the task

@4e6 4e6 mentioned this issue Oct 2, 2023
3 tasks
@jdunkerley jdunkerley moved this from 🔧 Implementation to 👁️ Code review in Issues Board Oct 3, 2023
@enso-bot
Copy link

enso-bot bot commented Oct 3, 2023

Dmitry Bushev reports a new STANDUP for yesterday (2023-10-02):

Progress: Continue working on the issue. Added a graalvm version to the build config. Update the run build script logic to create a bundle runtime directory based on the config values. Tested with IDE. Created the PR It should be finished by 2023-10-02.

Next Day: Next day I will be working on the #7871 task. Continue working on the task

@mergify mergify bot closed this as completed in #7948 Oct 6, 2023
mergify bot pushed a commit that referenced this issue Oct 6, 2023
close #7871
close #7698

Changelog:
- fix: the `run` script logic to place the GraalVM runtime in the expected directory when building the bundle
- fix: the `makeBundles` SBT logic to place the GraalVM runtime in the expected directory
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants