Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listing projects should not attempt to resolve editions #7834

Closed
hubertp opened this issue Sep 18, 2023 · 0 comments · Fixed by #7868
Closed

Listing projects should not attempt to resolve editions #7834

hubertp opened this issue Sep 18, 2023 · 0 comments · Fixed by #7868
Assignees
@4e6
Labels
-compiler -project-manager

Comments

@hubertp
Copy link
Collaborator

hubertp commented Sep 18, 2023

Refactored from a comment to a PR:

[DEBUG] [2023-09-12T10:27:56+02:00] [org.enso.projectmanager.requesthandler.ProjectListHandler] started (org.enso.projectmanager.requesthandler.ProjectListHandler@341bbd41)
[DEBUG] [2023-09-12T10:27:56+02:00] [org.enso.downloader.http.HTTPDownload] Fetching [https://editions.release.enso.org/enso/manifest.yaml].
[WARN] [2023-09-12T10:27:56+02:00] [org.enso.projectmanager.service.ProjectService] Could not resolve engine version for Edition(Some(2023.2.1-nightly.2023.8.15),None,Map(),Map()). Falling back to Edition(Some(0.0.0-dev),None,Map(),Map())
[DEBUG] [2023-09-12T10:27:56+02:00] [org.enso.downloader.http.HTTPDownload] Fetching [https://editions.release.enso.org/enso/manifest.yaml].

It makes little sense to check the edition of a project that will unlikely to be opened.
@jdunkerley jdunkerley assigned 4e6 and unassigned hubertp Sep 26, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Sep 26, 2023
@hubertp hubertp moved this from 📤 Backlog to 👁️ Code review in Issues Board Sep 26, 2023
This was referenced Sep 26, 2023
Merged
Closed
@mergify mergify bot closed this as completed in #7868 Sep 28, 2023
mergify bot pushed a commit that referenced this issue Sep 28, 2023
@4e6
Open projects using the packaged language server (#7868)
71442fe 
close #7750
close #7834

Changelog:
- update: project manager uses the packaged language server to open projects
- fix: remove stack traces from connection errors on initial ping handler request (when the language server is booting)
- update: add engine and edition versions to the `initProtocolConnection` response for easier debug
- update: do not resolve project ensoVersion in the `project/list` to eliminate unnecessary network calls
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4e6 4e6

Labels
-compiler -project-manager
Projects
Issues Board
Archived in project
Milestone
No milestone
3 participants
@hubertp @4e6 @JaroslavTulach