Cache result of slow function resolution on Any that is present on a hot path #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
added
the
CI: No changelog needed
Akirathan
reviewed
May 3, 2023
engine/runtime/src/main/java/org/enso/interpreter/node/callable/InvokeMethodNode.java
Outdated
Show resolved
Hide resolved
hubertp
force-pushed
the
wip/hubert/6523-fix-test-benchmarks
branch
from
d771f6f to
d0c57ba
Compare
JaroslavTulach
approved these changes
May 4, 2023
engine/runtime/src/main/java/org/enso/interpreter/node/callable/InvokeMethodNode.java
Show resolved
Hide resolved
Otherwise things can go horribly slow. Closes #6523.
As per PR review
Applying PR review. Had to be a bit careful so that we don't trip on automatic resource managment on `self`.
hubertp
force-pushed
the
wip/hubert/6523-fix-test-benchmarks
branch
from
834df4f to
cafffaa
Compare
hubertp
changed the title
hubertp
changed the title
| "cachedSymbol == symbol", | ||
| "cachedSelfTpe == typesLibrary.getType(self)", | ||
| "function != null" | ||
| }, limit = "CACHE_SIZE") |
Procrat
added a commit
that referenced
this pull request
May 4, 2023
…-5075 * develop: Build nightly 3 hours earlier. (#6551) Cache result of slow function resolution on Any that is present on a hot path (#6536) Fix cut-off in text visualisations (#6421) Infer correct synthetic name for nested modules (#6525) Delete unused websocket dependency (#6535) Run typecheck and eslint on `./run lint` (#6314) Force pending saves if client closes abruptly (#6514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Otherwise things can go horribly slow.
Closes #6523. Follow up on #6441.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.