Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/Benchmarks appear to never finish #6523

Closed
hubertp opened this issue May 3, 2023 · 3 comments · Fixed by #6536
Closed

test/Benchmarks appear to never finish #6523

hubertp opened this issue May 3, 2023 · 3 comments · Fixed by #6536
Assignees
@hubertp
Labels
--regression Important: regression -compiler p-high Should be completed in the next sprint

Comments

@hubertp
Copy link
Collaborator

hubertp commented May 3, 2023 •
edited
Loading

Bisecting revealed the dispatch change to be the culprit.
Needs investigation.
@hubertp hubertp added -compiler --regression Important: regression labels May 3, 2023
@hubertp hubertp self-assigned this May 3, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board May 3, 2023
@hubertp hubertp moved this from ❓New to 🔧 Implementation in Issues Board May 3, 2023
@hubertp hubertp added the p-high Should be completed in the next sprint label May 3, 2023
@hubertp
Copy link
Collaborator Author

hubertp commented May 3, 2023 •
edited
Loading

It appears that https://github.com/enso-org/enso/blob/develop/engine/runtime/src/main/java/org/enso/interpreter/node/callable/InvokeMethodNode.java#L125 somehow leads to a circular dependency when resolving symbol of Meta.meta. I wonder if Any importing Meta has anything to do with it.

hubertp added a commit that referenced this issue May 3, 2023
@hubertp
Cache resolution of symbol for Any
80a65be 
Otherwise things can go horribly slow.
Closes #6523.
@hubertp hubertp mentioned this issue May 3, 2023
Merged
2 tasks
@hubertp hubertp moved this from 🔧 Implementation to 👁️ Code review in Issues Board May 3, 2023
hubertp added a commit that referenced this issue May 4, 2023
@hubertp
Cache resolution of symbol for Any
317ef5c 
Otherwise things can go horribly slow.
Closes #6523.
@mergify mergify bot closed this as completed in #6536 May 4, 2023
mergify bot pushed a commit that referenced this issue May 4, 2023
@hubertp
Cache result of slow function resolution on Any that is present on a …
6527312 
…hot path (#6536)

Otherwise things can go horribly slow.
Closes #6523. Follow up on #6441.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board May 4, 2023
@enso-bot
Copy link

enso-bot bot commented May 4, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-05-03):

Progress: Investigating reported problem with benchmarks. Bisecting revealed that changing resolution for functions is the culprit. Preliminary PR is up; identified slow symbol resolution for Any that is present on the hot path. Finished test case for #6525. Fighting with random failures on CI. Started looking into artificially limiting number of warnings attached to values. It should be finished by 2023-05-04.

Next Day: Next day I will be working on the #6523 task. Not quite happy with the solution, will need further improvements and testing.

@enso-bot
Copy link

enso-bot bot commented May 5, 2023

Hubert Plociniczak reports a new STANDUP for yesterday (2023-05-04):

Progress: More tweaks to inline caching as per review. Trying to reproduce #6515 given more logs. Looks like there is some race-condition on shutdown. Verifying FQN/Import bug #6553. Adding limit to reported warnings and more benchmarks. It should be finished by 2023-05-04.

Next Day: Next day I will be working on the #6523 task. More tweaks to warnings, take over renaming project bug from Dmitry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hubertp hubertp

Labels
--regression Important: regression -compiler p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cache result of slow function resolution on Any that is present on a hot path enso-org/enso
1 participant
@hubertp