Force pending saves if client closes abruptly #6514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertp
commented
May 2, 2023
| @@ -292,6 +292,11 @@ class LanguageServerController( | |||
| maybeRequester.foreach(_ ! ServerShutdownTimedOut) | |||
| stop() | |||
|
|
|||
| case ClientDisconnected(clientId) => | |||
There was a problem hiding this comment.
Extra change that deals with unexpected messages during shutdown:
INFO ide_ci::program::command: enso⚠️ [warn] [2023-05-01T10:29:13.187Z] [org.enso.projectmanager.boot.ProjectManager$] Failed to read line.
INFO ide_ci::program::command: enso⚠️ [info] [2023-05-01T10:29:13.187Z] [org.enso.projectmanager.boot.ProjectManager$] Stopping server...
INFO ide_ci::program::command: enso⚠️ [info] [2023-05-01T10:29:13.188Z] [org.enso.projectmanager.infrastructure.languageserver.LanguageServerKiller] Killing all servers [List(Actor[akka://project-manager/user/language-server-registry/language-server-controller-21260df1-f569-43d3-b2b2-d70944d8db8b#1107631448])].
INFO ide_ci::program::command: enso⚠️ [info] [2023-05-01T10:29:13.19Z] [org.enso.projectmanager.protocol.ClientController] Client disconnected from the Project Manager [9388d3fc-ac7d-4158-96b5-aea97429966b]
INFO ide_ci::program::command: enso⚠️ [warn] [2023-05-01T10:29:13.19Z] [org.enso.projectmanager.infrastructure.languageserver.LanguageServerController] Received unknown message: class org.enso.projectmanager.event.ClientEvent$ClientDisconnected
hubertp
added
the
CI: No changelog needed
hubertp
force-pushed
the
wip/hubert/6395-force-pending-saves-on-close
branch
from
3a09bd9 to
92bb306
Compare
JaroslavTulach
approved these changes
May 3, 2023
Akirathan
approved these changes
May 3, 2023
hubertp
added
the
CI: Clean build required
Haven't been able to reproduce but, theoritically, it is possible for pending applies to not be saved when shutting down.
When JsonSession is terminated we didn't force pending auto-saves.
hubertp
force-pushed
the
wip/hubert/6395-force-pending-saves-on-close
branch
from
92bb306 to
8e25690
Compare
Procrat
added a commit
that referenced
this pull request
May 4, 2023
* develop: Fix cut-off in text visualisations (#6421) Infer correct synthetic name for nested modules (#6525) Delete unused websocket dependency (#6535) Run typecheck and eslint on `./run lint` (#6314) Force pending saves if client closes abruptly (#6514) Continued Execution Context work and some little fixes (#6506) IDE's logging to a file (#6478) Fix application config (#6513) Cloud/desktop mode switcher (#6448) Fix doubled named arguments bug (#6422) Reimplement `enso_project` as a proper builtin (#6352) Fix layer ordering between dropdown and breadcrumbs backgrounds. (#6483) Multiflavor layers (#6477) DataflowAnalysis preserves dependencies order (#6493) Implement `create_database_table` for Database Table (#6467) Limit Dead Letter logging (#6482) More reliable shutdown of the EnsoContext to save resources (#6468) Make execution mode `live` default for CLI (#6496)
Procrat
added a commit
that referenced
this pull request
May 4, 2023
…-5075 * develop: Build nightly 3 hours earlier. (#6551) Cache result of slow function resolution on Any that is present on a hot path (#6536) Fix cut-off in text visualisations (#6421) Infer correct synthetic name for nested modules (#6525) Delete unused websocket dependency (#6535) Run typecheck and eslint on `./run lint` (#6314) Force pending saves if client closes abruptly (#6514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Force pending saves when JsonSession is terminated for the client.
Potentially closes #6395.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.