Fixing the node.js dependencies, so the VSCode plugin can be built again #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
CI: Ready to merge
JaroslavTulach
commented
Feb 23, 2023
| "vsce": "^2.6.4", | ||
| "webpack": "^5.40.0", | ||
| "webpack-cli": "^4.7.2" | ||
| "@types/xml2js": "=0.4.11", |
There was a problem hiding this comment.
Using ^ allows the node to download new version of the same library. That's often dangerous as new versions may not be fully compatible with previous ones. Using = to fix to an exact version of each library. This configuration is known to work.
|
The VSIX extension is really built by our GitHub actions now. I guess this proves the node.js dependencies are now correct. @mwu-tow, if you agree, please merge. Thank you. |
4e6
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixing node.js dependencies as:
was broken. Making sure the VSIX build is part of the actions workflow.
Important Notes
To reproduce/verify remove
enso/tools/enso4igv/node_modulesfirst and try to build.Checklist
Please include the following checklist in your PR:
style guides.