Dropdown for Table.join right is wrong

[wdanilo]

This task is automatically imported from the old Task Issue Board and it was originally created by jaroslavtulach.
Original issue is here.

---

Discovered during book clubing.

There is a drop down for Table.join right argument! And it offers Table.Value. Table.Value is just a function which needs a parameter of java_table, so it makes no sense to offer it as tag_value.

Comments:

(jaroslavtulach - Feb 2, 2023)

---

[jdunkerley]

Please let us know how to determine what ends up in tagValues and the logic we need to control this.

[JaroslavTulach]

To determine what ends up in tagValues one needs to put breakpoint to buildResolvedUnionTypeName. Or better have three breakpoints:

enso$ git diff engine/runtime/src/main/scala/org/enso/compiler/context/SuggestionBuilder.scala
diff --git a/engine/runtime/src/main/scala/org/enso/compiler/context/SuggestionBuilder.scala b/engine/runtime/src/main/scala/org/enso/compiler/context/SuggestionBuilder.scala
index b2161b2d3..23d9789da 100644
--- a/engine/runtime/src/main/scala/org/enso/compiler/context/SuggestionBuilder.scala
+++ b/engine/runtime/src/main/scala/org/enso/compiler/context/SuggestionBuilder.scala
@@ -106,6 +106,9 @@ final class SuggestionBuilder[A: IndexedSource](
                   _
                 ) if !m.isStaticWrapperForInstanceMethod =>
             val typeSignature = ir.getMetadata(TypeSignatures)
+            if (methodName.toString().contains("join")) {
+                System.out.println("Found method " + methodName)
+            }
             val (selfTypeOpt, isStatic) = typePtr match {
               case Some(typePtr) =>
                 val selfType = typePtr
@@ -200,6 +203,9 @@ final class SuggestionBuilder[A: IndexedSource](
     }
 
     val builder: TreeBuilder = Vector.newBuilder
+    if (module.toString().endsWith("Table")) {
+      System.err.println("Processing " + module)
+    }
     builder += Tree.Node(
       buildModule(
         module,

and stop when one is processing Standard.Table.Data.Table module and join method. Then stop in the buildResolvedUnionTypeName.

Doing that one finds out there is Value java_table which is seen as:

BindingsMap$Type
  name = "Table" 
  members = [ BindingsMap$Cons name="Value" arity = 1 allFieldsDefaulted=false ]

e.g. offering Table.Value is as good as offering Filter_Condition.Equal which is what #5656 wants to offer. Alas they aren't really distinguishable from the perspective of the SuggestionBuilder.

Ideas @jdunkerley, @Frizi & co.?

[hubertp]

@jdunkerley Here are is a clue from Dmitry that I once got on debugging suggestions:

If you want to observe the database, the easiest way is to create a file-based one instead of in-memory

enso/engine/language-server/src/main/scala/org/enso/languageserver/boot/MainModule.scala

Line 117 in c4c35c9

val sqlDatabase = SqlDatabase.inmem("memdb")

with
val sqlDatabase = SqlDatabase(languageServerConfig.directories.suggestionsDatabaseFile)
and then use CLI
$ sqlite3 /path/to/suggestions.db

[JaroslavTulach]

offering Table.Value is as good as offering Filter_Condition.Equal which is what #5656 wants to offer. Alas they aren't really distinguishable from the perspective of the SuggestionBuilder.

@jdunkerley proposes to ignore tagValues with a single entry in SuggestionBuilder. Let's do it!

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-02-23):

Progress: - PR with design for Table.Value ready for discussion: #5747

• some discussion about the design needed
• Meeting about IO contexts
• review Nan: NaN is a new builtin type #5744
• debugging JSON Serialization and deserialization
• finally understand how Jackson works: f413b62#r1116136929
• can serialize records: 958cc78
• discussion about TRegex It should be finished by 2023-03-06.

Next Day: Focus on serialization of suggestion cache.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-02-24):

Progress: - discussion about Table.Value (and now also Pair.Value) continues: #5747 (comment)

• Suggestions Serialization
  • can read them from Scala: 1ff4c25
  • Akka bus: Pre compute suggestion db during build time #5698 (comment)
• evaluating missing(?) getMetaObject(): getMetaObject for a primitive Value returns null unexpectedly #5759
• standup, pair programming and discussions
• hours of dicussions about ordering:
  • Lobbying for "partial ordering": NaN is a new builtin type #5744 (comment)
  • And its usage in sort: sort handles Incomparable types by default #5742 (comment) It should be finished by 2023-03-06.

Next Day: Vacation on Monday.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-02-25):

Progress: - Table.Value, Pair.Value - awaits: #5747 (comment)

• Familiarizing with BigInteger support in GraalVM 23.0:
• Just landed in the codebase: https://github.com/oracle/graal/pull/5490/files#diff-b9f3acd7cf907a1ea1fa5dd88bcb3c544622d1665cea25cdf1ffe54f4928738cR991
• proposing flexible sort: sort handles Incomparable types by default #5742 (comment)
• debugging suggestion DB It should be finished by 2023-03-06.

Next Day: Vacation on Monday.

GitHub

[GR-25539] Interop support for BigInteger. by graalvmbot · Pull Request #5490 · oracle/graal

GraalVM: Run Programs Faster Anywhere 🚀. Contribute to oracle/graal development by creating an account on GitHub.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-02-28):

Progress: - Table.Value solved and integrated

• Enso VSIX extension is really buildable: Fixing the node.js dependencies, so the VSCode plugin can be built again #5738
• fixed Parser NPE on dangling comma in Vector literal #5691 by Convert dangling comma into unexpected expression #5776
• review Pause/Play: https://github.com/enso-org/design/pull/53
• meetings & discussions
• debugging cache invalidation: Synthetic modules are not being serialized causing constant cache invalidation #5608 It should be finished by 2023-03-06.

Next Day: Cache invalidations & request timeout