Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the node.js dependencies, so the VSCode plugin can be built again #5738

Merged
merged 18 commits into from
Feb 28, 2023
+16 −10
Merged

Fixing the node.js dependencies, so the VSCode plugin can be built again #5738

Changes from 3 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e26f57a
Fixing the node.js dependencies, so the VSCode plugin can be built again
JaroslavTulach Feb 22, 2023
00836a8
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 22, 2023
22c2a42
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 23, 2023
f8307c0
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 23, 2023
ea29bd5
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 23, 2023
9ccb7e6
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 23, 2023
097ee5c
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 23, 2023
ad5529c
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 24, 2023
afa89a6
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 24, 2023
049c113
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 24, 2023
6c3cbf3
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 25, 2023
48a16ca
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 27, 2023
4a883db
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 27, 2023
519c80d
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 27, 2023
eb07185
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 27, 2023
84a8360
Explicitly build the VSIX extension as part of the actions workflow
JaroslavTulach Feb 28, 2023
1b980d5
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 28, 2023
ccda10a
Merge branch 'develop' into wip/jtulach/FixNodeDependenciesEnso4Igv
mergify[bot] Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions tools/enso4igv/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,19 +77,19 @@
"lint": "tslint -p ./"
},
"dependencies": {
"copy-webpack-plugin": "^10.2.4",
"decompress": "4.2.1",
"maven": "^5.0.0"
"copy-webpack-plugin": "=10.2.4",
"decompress": "=4.2.1",
"maven": "=5.0.0"
},
"devDependencies": {
"@types/vscode": "=1.49.0",
"@types/xml2js": "^0.4.8",
"ts-loader": "^6.2.1",
"tslint": "^6.1.0",
"typescript": "^3.9.10",
"vsce": "^2.6.4",
"webpack": "^5.40.0",
"webpack-cli": "^4.7.2"
"@types/xml2js": "=0.4.11",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ^ allows the node to download new version of the same library. That's often dangerous as new versions may not be fully compatible with previous ones. Using = to fix to an exact version of each library. This configuration is known to work.

"ts-loader": "=9.4.2",
"tslint": "=6.1.3",
"typescript": "=4.9.5",
"vsce": "=2.15.0",
"webpack": "=5.75.0",
"webpack-cli": "=5.0.1"
},
"extensionDependencies": [
"asf.apache-netbeans-java"
Expand Down