Alias analysis #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kustosz
reviewed
Jan 24, 2017
| varName :: MonadRef m => Expr Var -> SubPass AliasAnalysis m P.String | ||
| varName e = fmap (view lit) . match' =<< source =<< view name <$> match' e | ||
|
|
||
| modifyAttr :: forall m. MonadRef m => (RefData' Attr UsedVars (SubPass AliasAnalysis m) -> RefData' Attr UsedVars (SubPass AliasAnalysis m)) -> SubPass AliasAnalysis m () |
There was a problem hiding this comment.
Looks generally useful – how about generalizing the types and moving to Luna.IR.Internal.IR?
|
Type holes in specs + 2 fixes described in inline comments. Otherwise LGTM. |
kustosz
reviewed
Jan 24, 2017
| atLeastOneIsEqual <- forM args $ \(Arg _ n) -> do | ||
| n' <- source n | ||
| gatherVar n' f' | ||
| sameVar <- sameNameVar (unsafeRelayout properVar) (unsafeRelayout n') |
There was a problem hiding this comment.
Why the assumption that n' is a var? How about (Just (Just x)) : x
This was referenced Feb 6, 2023
5 tasks
Procrat
added a commit
that referenced
this pull request
May 26, 2023
* Remove unused code: project management in component browser * Encapsulate internal FRP logic of project list * Collapse some code paths * Open project passed on command line through presenter A project name or ID that is passed on the command line was initialised in the controller setup, before the presenters and views are set up. Now, we fully initialise the IDE before opening a project so we have control over the view while a project is being opened. * Show a spinner in all cases of opening a project * Let root presenter open/close projects when switching projects * Change spinner to make progress over a fixed period * Resolve issues when Project Manager API isn't available * Bump wasm size limit
Procrat
added a commit
that referenced
this pull request
May 30, 2023
…le-6756-6804 * develop: (22 commits) Coalesce graph editor view invalidations (#6786) Append warnings extracted before tail call execution (#6849) Detect and override hooks of the same kind (#6842) Dynamic app resampling and better performance measurements. (#6595) Show spinner when opening/creating a project, take #2 (#6827) Infrastructure for testing inter project imports and exports (#6840) Only initialise visualisation chooser if it is used. (#6758) Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771) Update GraalVM to 22.3.1 JDK17 (#6750) Import/export syntax error have more specific messages (#6808) ...
5 tasks
farmaazon
added a commit
that referenced
this pull request
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.