Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Show spinner when opening/creating a project, take #2 (#6827)" #7229

Merged
merged 4 commits into from
Jul 14, 2023

Conversation

farmaazon
Copy link
Contributor

This reverts commit 0ed78f9.

Fixes #7163

As it turned out, the issue with missing retries is quite important, because IDE does not launch on weak hardware. Reverting that commit is an easy way to fix it (and the loading spinner could be implemented in a better way, with cooperation with the new dashboard).

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@farmaazon farmaazon self-assigned this Jul 6, 2023
@farmaazon
Copy link
Contributor Author

I expected the revert will just remove the "second" loading screen, but it's still there giving strange effect:

strange-2023-07-06_14.51.04.mp4

@PabloBuchu @somebody1234 as you know the dashboard more or less, do you know if there is some code in dashboard which makes the second loading screen? I haven't found anything in rust code.

@somebody1234
Copy link
Contributor

oh you mean does the dashboard explicitly run a loading spinner? afaict no - the dashboard code actually doesn't have a full-screen loading spinner (nor one with the logo)
it's possible the entry point triggers the spinner somehow via the loader, but i don't think that should happen either.

i can see some logs are seemingly duplicated, may that be related?
it reminds me of React logging things twice in its debug mode, so it may be caused by debug mode?

@somebody1234
Copy link
Contributor

if it's possible to set a breakpoint on show_progress_indicator that might help with debugging?
alternatively you could try -authentication=false -feature=preview.new-dashboard=false -startup.project=<project here> which should be equivalent (and so should theoretically show only one spinner, if the dashboard is probably the cause)

@jdunkerley
Copy link
Member

Testing on a weak VM this fix works and can get a not very usable but at least working instance of Enso.

@farmaazon farmaazon added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 12, 2023
@farmaazon
Copy link
Contributor Author

Hmm, the effect is gone after merging develop. I like it.

Now, I only need an owner's accept. @MichaelMauderer or @wdanilo

@farmaazon farmaazon marked this pull request as ready for review July 12, 2023 10:17
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Jul 13, 2023
@farmaazon farmaazon force-pushed the wip/farmaazon/revert-spinner branch from bd80ff4 to 0051417 Compare July 14, 2023 13:48
@mergify mergify bot merged commit 853dd2f into develop Jul 14, 2023
@mergify mergify bot deleted the wip/farmaazon/revert-spinner branch July 14, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE does not retry to open project
4 participants