-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Show spinner when opening/creating a project, take #2 (#6827)" #7229
Conversation
I expected the revert will just remove the "second" loading screen, but it's still there giving strange effect: strange-2023-07-06_14.51.04.mp4@PabloBuchu @somebody1234 as you know the dashboard more or less, do you know if there is some code in dashboard which makes the second loading screen? I haven't found anything in rust code. |
oh you mean does the dashboard explicitly run a loading spinner? afaict no - the dashboard code actually doesn't have a full-screen loading spinner (nor one with the logo) i can see some logs are seemingly duplicated, may that be related? |
if it's possible to set a breakpoint on |
Testing on a weak VM this fix works and can get a not very usable but at least working instance of Enso. |
Hmm, the effect is gone after merging develop. I like it. Now, I only need an owner's accept. @MichaelMauderer or @wdanilo |
bd80ff4
to
0051417
Compare
This reverts commit 0ed78f9.
Fixes #7163
As it turned out, the issue with missing retries is quite important, because IDE does not launch on weak hardware. Reverting that commit is an easy way to fix it (and the loading spinner could be implemented in a better way, with cooperation with the new dashboard).
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.