Only initialise visualisation chooser if it is used. #6758
Conversation
MichaelMauderer
requested review from
wdanilo,
farmaazon and
kazcw
as code owners
MichaelMauderer
added
the
CI: No changelog needed
app/gui/view/graph-editor/src/component/visualization/container/action_bar.rs
Outdated
Show resolved
Hide resolved
…r/action_bar.rs Co-authored-by: Adam Obuchowicz <[email protected]>
|
QA: I think there might be a small regression here. When I hover over the visualisation of an existing node in a newly opened project, it reverts back to the loading animation. See 0:13 in this video: 2023-05-24.11-09-57.online-video-cutter.com.mp4 |
This is now fixed. @Procrat |
|
|
||
| // Note: we only want to update the chooser if it is visible, or when it becomes | ||
| // visible. Thus we avoid many simultaneous updates during initialisation. | ||
|
|
There was a problem hiding this comment.
I don't understand this comment. What do you mean by "many simultaneous updates during initialization"? Why updating the chosen while it is invisible would cause many simultaneous updates?
There was a problem hiding this comment.
We update all choosers upon first receiving types from the engine (the initialization), which is mostly pointless given they are not visible (and they content may easily be changed again before it will be actually shown).
There was a problem hiding this comment.
Ok, @MichaelMauderer, would you be able to add this (^^^) information to the comment there as well, please? It would make (at least for me) it way more understandable.
|
By "This avoids initializing lots of invisible UI elements at the same time when opening a project." - do you mean that currently multiple visualizations are initialized even if they should not? |
QA: Sweet! Looks good to me! |
MichaelMauderer
added
the
CI: Ready to merge
mergify
bot
deleted the
wip/MichaelMauderer/Delay_Initialisation_Of_Hidden_Action_Bars
branch
…le-6756-6804 * develop: (22 commits) Coalesce graph editor view invalidations (#6786) Append warnings extracted before tail call execution (#6849) Detect and override hooks of the same kind (#6842) Dynamic app resampling and better performance measurements. (#6595) Show spinner when opening/creating a project, take #2 (#6827) Infrastructure for testing inter project imports and exports (#6840) Only initialise visualisation chooser if it is used. (#6758) Allow casting a Mixed column into a concrete type (#6777) Stop graph editing when in full-screen visualization mode (#6844) Handle `show-dashboard` event (#6837) Fix some dashboard issues (#6668) Fix JWT leak (#6815) Fix "set username" screen (#6824) Fallback to opened date when ordering projects (#6814) Various test improvements to increase coverage and speed things up (#6820) do not activate nested dropdowns together (#6830) Clearly select single specialization with enum dispatch pattern (#6819) Prevent incorrect application of list widget on incompatible expressions (#6771) Update GraalVM to 22.3.1 JDK17 (#6750) Import/export syntax error have more specific messages (#6808) ...
Pull Request Description
Re-introduce a feature that was removed with #6638: only initialize visualization choosers when they are visible. This avoids initializing lots of invisible UI elements at the same time when opening a project.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.