Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding components inside a group incorrectly adds the component at the parent level #9049

Closed
AdRiley opened this issue Feb 13, 2024 · 5 comments · Fixed by #9060
Closed

Adding components inside a group incorrectly adds the component at the parent level #9049

AdRiley opened this issue Feb 13, 2024 · 5 comments · Fixed by #9060
Assignees
Labels
--bug Type: bug -gui p-high Should be completed in the next sprint
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 13, 2024

Create the below workflow

image

Select the middle 2 components and press CTRL-G to group them

image

Double click on Main.collapsed to enter the grouped workflow

image

Drag from the .+ 3 output port to create a new component and try to add .+ 5.

Node does not appear to get added

image

Double click on background to return to parent workflow. Node has been incorrectly added there.

image

@AdRiley AdRiley added p-high Should be completed in the next sprint --bug Type: bug -gui labels Feb 13, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 13, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 14, 2024
@farmaazon farmaazon self-assigned this Feb 14, 2024
@farmaazon farmaazon moved this from 📤 Backlog to 👁️ Code review in Issues Board Feb 14, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 15, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-02-14):

Progress: Created a fix. Discovered that the thing is hard to test in our current code. Tried some careful refactoring, but it turned out it has to be much bigger - created a task for that. Besides, did the bookclub and rearranged task to be ready for being refined tomorrow. It should be finished by 2024-02-15.

Next Day: Next day I will be working on the #8963 task. Take some next task from backlog

@mergify mergify bot closed this as completed in #9060 Feb 19, 2024
mergify bot pushed a commit that referenced this issue Feb 19, 2024
Fixes #9049

There were still some stubs left in node creation code.

# Important Notes
I haven't added any tests, as unit testing the graph store is very difficult - it has much tangled logic there. I'm going to try to untangle it a bit, but in a separate PR.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 19, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Feb 20, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Adam Obuchowicz reports a new 🔴 DELAY for yesterday (2024-02-19):

Summary: There is 4 days delay in implementation of the Adding components inside a group incorrectly adds the component at the parent level (#9049) task.
It will cause 4 days delay for the delivery of this weekly plan.

Delay Cause: Two days of sick leave

@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-02-19):

Progress: Catching up after being off, planning, meetings and reviews. Merged the PR with fix for creating nodes inside functions. It should be finished by 2024-02-19.

Next Day: Next day I will be working on the #8942 task. New transient failures have arisen, I need to check them.

@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Adam Obuchowicz reports a new 🔴 DELAY for today (2024-02-20):

Summary: There is 3 days delay in implementation of the Adding components inside a group incorrectly adds the component at the parent level (#9049) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: The stream of E2E failures seem to be not exthaused. But this time they caught a potential real issue in our App

@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-02-20):

Progress: When tried to reproduce locally, I found something in log what could be the cause of the issue: when quick clicking at breadcrumbs in tests, some clicks are interpreted as double clicking background. Started refactoring things to make sure no such click leaking occurs, and also unifying the way we interact with user clicks (click vs pointerdown). Still checking some issues in CB. It should be finished by 2024-02-22.

Next Day: Next day I will be working on the same task. Fix issues and make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui p-high Should be completed in the next sprint
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants