Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI E2E tests transient failures #8942

Closed
12 tasks done
Tracked by #8518
farmaazon opened this issue Feb 2, 2024 · 8 comments
Closed
12 tasks done
Tracked by #8518

GUI E2E tests transient failures #8942

farmaazon opened this issue Feb 2, 2024 · 8 comments
Assignees
@farmaazon
Labels
--bug Type: bug -gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Feb 2, 2024 •
edited
Loading

Gathered from various failed CI jobs:
@farmaazon farmaazon mentioned this issue Feb 2, 2024
Closed
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Feb 2, 2024
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint --bug Type: bug -gui labels Feb 2, 2024
@farmaazon farmaazon self-assigned this Feb 2, 2024
@enso-bot enso-bot bot mentioned this issue Feb 2, 2024
Closed
@farmaazon farmaazon mentioned this issue Feb 2, 2024
Merged
5 tasks
@farmaazon farmaazon moved this from ❓New to 🔧 Implementation in Issues Board Feb 2, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 2, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-02-02):

Progress: Gathered some CI failures related to new tests from CI. Examined and created PR with fixes. Also made another PR with small fixes like "select node after creating". Also, made an urgent fix for broken develop after last big change It should be finished by 2024-02-07.

Next Day: Next day I will be working on the same task. Check if any other failure will show up. Or take another task.

mergify bot pushed a commit that referenced this issue Feb 5, 2024
@farmaazon
Reduce test flakiness (#8947)
fa4b980 
Probably fixes the first point in #8942

My guess is that the mockExpressionUpdate may be not set in cases when the test runs before App mounting. To make sure all the setup is done, we wait for `App` widget to being mounted before proceeding.

# Important Notes
This PR also change the way we run test's server. Before it was always a production build, but this makes development iteration long. Now we test production build only on CI or when `PROD=true` env variable is set.
MichaelMauderer pushed a commit that referenced this issue Feb 6, 2024
@farmaazon @MichaelMauderer
Reduce test flakiness (#8947)
2c788ac 
Probably fixes the first point in #8942

My guess is that the mockExpressionUpdate may be not set in cases when the test runs before App mounting. To make sure all the setup is done, we wait for `App` widget to being mounted before proceeding.

# Important Notes
This PR also change the way we run test's server. Before it was always a production build, but this makes development iteration long. Now we test production build only on CI or when `PROD=true` env variable is set.
@AdRiley AdRiley added this to the Beta Release milestone Feb 8, 2024
@farmaazon
Copy link
Contributor Author

"Binding not found" is not test issue, and it seems it's a bug of one of our dependencies: Menci/vite-plugin-top-level-await#25. I've created a PR to remove it.

@farmaazon farmaazon mentioned this issue Feb 19, 2024
Closed
@enso-bot enso-bot bot mentioned this issue Feb 20, 2024
Closed
@farmaazon farmaazon mentioned this issue Feb 21, 2024
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Feb 21, 2024

Adam Obuchowicz reports a new 🔴 DELAY for today (2024-02-21):

Summary: There is 14 days delay in implementation of the GUI E2E tests transient failures (#8942) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: Yesterday fiilled delay (and standup) to wrong issue: #9049 (comment)

Possible solutions: Be more wary

@enso-bot
Copy link

enso-bot bot commented Feb 21, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-02-21):

Progress: Finished fixing click handlers and a bit more. Created a PR. It should be finished by 2024-02-21.

Next Day: Next day I will be working on the #9058 task. Start working on drop down filtering.

mergify bot pushed a commit that referenced this issue Feb 22, 2024
@farmaazon
Fix interfering click handlers (#9127)
7f5b2ed 
Fixes one failure in #8942 which caught a real issue: clicks at various panels were triggering many handlers at once, often unexpectedly - for example quick clicking at breadcrumbs (and automatic tests always click fast) we could also trigger getting out the current node.

Therefore, I added `stopPropagation` for all mouse events on "panel" level + where I think the event should be considered "handled" and no longer bother anyone. Also, to unify things, most actions are for `click` event.

Additionally I spotted and fixed some issues:
* When "clicking-off" Component Browser, it creates new node only if anything was actually typed in (no more dangling `operatorX.` nodes)
* Filtering now works for operators
* When, after opening CB with source node, user starts typing operator, we replace dot with space
* Fixed our shortcut handler, so it works properly with `click` event.
* Fixed problems with defocusing input in CB when clicking at links.

# Important Notes
I removed `PointerMain` binding for deselectAll, because it was triggered every time did the area selection.
@Akirathan
Copy link
Member

Akirathan commented Feb 28, 2024 •
edited by unfurl-links bot
Loading

Bumped into:

 INFO ide_ci::program::command: npmℹ️   1) componentBrowser.spec.ts:124:1 › Filling input with suggestions ───────────────────────────────
 INFO ide_ci::program::command: npmℹ️ 
 INFO ide_ci::program::command: npmℹ️     Test timeout of 30000ms exceeded.

in https://github.com/enso-org/enso/actions/runs/8084013760/job/22088345557?pr=9075#step:8:671

That does not seem to be covered by the list in the description.

GitHub
Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

@enso-bot enso-bot bot mentioned this issue Feb 29, 2024
Closed
@enso-bot
Copy link

enso-bot bot commented Mar 1, 2024

Adam Obuchowicz reports a new 🔴 DELAY for today (2024-03-01):

Summary: There is 12 days delay in implementation of the GUI E2E tests transient failures (#8942) task.
It will cause 3 days delay for the delivery of this weekly plan.

Delay Cause: New failures emerged.

@enso-bot
Copy link

enso-bot bot commented Mar 1, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-03-01):

Progress: Fixed last problems I found with E2E tests. Also, added config to eslint to catch missing awaits (the most common problem so far). And, to make investigation easier, make reports with exact trace to be downloaded from GH actions. It should be finished by 2024-03-04.

Next Day: Next day I will be working on the #9058 task. Resume work on filtering.

@farmaazon
Copy link
Contributor Author

The issues in this task seem to be fixed. Closing for now, let's report new issues in new issues.

@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Mar 13, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmaazon farmaazon

Labels
--bug Type: bug -gui d-intermediate Difficulty: some prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

No branches or pull requests
3 participants
@AdRiley @farmaazon @Akirathan