-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto layout doesn't take the connections into account when placing nodes #8963
Comments
Note: Just put them from top to bottom as in file. This ensures topological order. |
Adam Obuchowicz reports a new STANDUP for today (2024-02-07): Progress: Made a fix for old nodes being visible for a moment after switching project. Also implemented small fixes for boolean. It should be finished by 2024-02-12. Next Day: Next day I will be working on the same task. Merge PR and plan next tasks |
This seems to be fixed by c811a5a. Before this commit, I observed that removing the metadata of a program results in the graph being updated with a reversed layout, as in the screenshot above. After this commit, this behaviour is gone and the layout is correct. New projects without metadata seem to be laid out correctly before and after this commit. |
Let's yet investigate if the nodes are actually sorted, or we get the proper order by chance. |
Michael Mauderer reports a new 🔴 DELAY for today (2024-02-20): Summary: There is 10 days delay in implementation of the Auto layout doesn't take the connections into account when placing nodes (#8963) task. Delay Cause: There was a previous standup reported on this issue by Adam. This task was newly picked up now by me. Possible solutions: Never put tasks back in the backlog or allow this to be better reported for enso bot. |
Michael Mauderer reports a new STANDUP for today (2024-02-20): Progress: Opened PR for previous task. Started investigasting issue and found it resolved on develop. After standup discussion we decided to continue investigation into the root cause, which likely still exists. It should be finished by 2024-02-21. Next Day: Next day I will be working on the #8963 task. Find root cause and eitehr fix it or confirm this is no problem. |
Michael Mauderer reports a new STANDUP for yesterday (2024-02-21): Progress: Identified root cause, and the place where the order of node updates is determined. This is now reliably in the correct order and added new documentation pointing out why and how this is happening, ensuring this is noted and not broken in the future. It should be finished by 2024-02-21. Next Day: Next day I will be working on the #8995 task. Start next task. |
For example, when creating "Geospatial analysis" example and removing metadata, all nodes seem to be laid out backwards (so all connections are going up)
The text was updated successfully, but these errors were encountered: