Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto layout doesn't take the connections into account when placing nodes #8963

Closed
farmaazon opened this issue Feb 5, 2024 · 7 comments · Fixed by #9141
Closed

Auto layout doesn't take the connections into account when placing nodes #8963

farmaazon opened this issue Feb 5, 2024 · 7 comments · Fixed by #9141
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Milestone

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Feb 5, 2024

For example, when creating "Geospatial analysis" example and removing metadata, all nodes seem to be laid out backwards (so all connections are going up)

Image

@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Feb 5, 2024
@farmaazon farmaazon mentioned this issue Feb 5, 2024
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints -gui labels Feb 5, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 5, 2024
@farmaazon
Copy link
Contributor Author

Note: Just put them from top to bottom as in file. This ensures topological order.

@enso-bot
Copy link

enso-bot bot commented Feb 7, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-02-07):

Progress: Made a fix for old nodes being visible for a moment after switching project. Also implemented small fixes for boolean. It should be finished by 2024-02-12.

Next Day: Next day I will be working on the same task. Merge PR and plan next tasks

@MichaelMauderer
Copy link
Contributor

This seems to be fixed by c811a5a.

Before this commit, I observed that removing the metadata of a program results in the graph being updated with a reversed layout, as in the screenshot above. After this commit, this behaviour is gone and the layout is correct.

New projects without metadata seem to be laid out correctly before and after this commit.

@MichaelMauderer MichaelMauderer moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 20, 2024
@farmaazon farmaazon moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Feb 20, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🔧 Implementation in Issues Board Feb 20, 2024
@farmaazon
Copy link
Contributor Author

Let's yet investigate if the nodes are actually sorted, or we get the proper order by chance.

@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Michael Mauderer reports a new 🔴 DELAY for today (2024-02-20):

Summary: There is 10 days delay in implementation of the Auto layout doesn't take the connections into account when placing nodes (#8963) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: There was a previous standup reported on this issue by Adam. This task was newly picked up now by me.

Possible solutions: Never put tasks back in the backlog or allow this to be better reported for enso bot.

@enso-bot
Copy link

enso-bot bot commented Feb 20, 2024

Michael Mauderer reports a new STANDUP for today (2024-02-20):

Progress: Opened PR for previous task. Started investigasting issue and found it resolved on develop. After standup discussion we decided to continue investigation into the root cause, which likely still exists. It should be finished by 2024-02-21.

Next Day: Next day I will be working on the #8963 task. Find root cause and eitehr fix it or confirm this is no problem.

@MichaelMauderer MichaelMauderer moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 22, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 22, 2024

Michael Mauderer reports a new STANDUP for yesterday (2024-02-21):

Progress: Identified root cause, and the place where the order of node updates is determined. This is now reliably in the correct order and added new documentation pointing out why and how this is happening, ensuring this is noted and not broken in the future. It should be finished by 2024-02-21.

Next Day: Next day I will be working on the #8995 task. Start next task.

@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 23, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants