Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize JLine terminal asynchronously #8688

Closed
Akirathan opened this issue Jan 5, 2024 · 2 comments · Fixed by #11149
Closed

Initialize JLine terminal asynchronously #8688

Akirathan opened this issue Jan 5, 2024 · 2 comments · Fixed by #11149
Assignees
Labels
--low-performance -compiler p-medium Should be completed in the next few sprints

Comments

@Akirathan
Copy link
Member

#8496 switched from DumbTerminal to a proper JLine terminal. This adds 80 ms to the startup time.

image
fast.nps is a profiling snapshot from #8553 (comment) (from older revision before #8496) and t.nps is after #8596.

We can see that there is roughly 80 ms difference in makeTerminalForRepl. Moreover, we can see that in fast.nps, only DumbTerminal is initialized.

Both profiling snapshots are attached in profilings.zip

Let's initialize the JLine terminal asynchronously.

@Akirathan Akirathan added p-medium Should be completed in the next few sprints -compiler --low-performance labels Jan 5, 2024
@Akirathan Akirathan self-assigned this Jan 5, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Jan 5, 2024
@Akirathan
Copy link
Member Author

Duplicated by #8690

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Jan 9, 2024
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to 👁️ Code review in Issues Board Sep 23, 2024
@enso-bot
Copy link

enso-bot bot commented Sep 24, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-09-23):

Progress: .

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--low-performance -compiler p-medium Should be completed in the next few sprints
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

2 participants