Grouping Executors related methods into a single class #9271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
JaroslavTulach
force-pushed
the
jtulach/ExecutorsFactory
branch
from
5021c6d to
ca2e6ae
Compare
3 tasks
|
FYI: @ola-lis has created an official ticket in My Oracle Support requesting fix for the Helidon 4 + Graal.js on native-image for JDK21 problem:
E.g. by accepting this PR you'd help to resolve an official Oracle Java SE JDK and JRE licensee request. |
Copyright and javadoc fix.
tomas-langer
previously approved these changes
Sep 23, 2024
Signed-off-by: Tomas Langer <[email protected]>
tomas-langer
approved these changes
Sep 23, 2024
|
Thank you Tomáši for fixing formatting & co. |
JaroslavTulach
added a commit
to enso-org/enso
that referenced
this pull request
Sep 24, 2024
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Sep 27, 2024
* Grouping Executors related methods into a single class Signed-off-by: Tomas Langer <[email protected]> Co-authored-by: Tomas Langer <[email protected]>
barchetta
added a commit
that referenced
this pull request
Sep 30, 2024
* Grouping Executors related methods into a single class Signed-off-by: Tomas Langer <[email protected]> Co-authored-by: Jaroslav Tulach <[email protected]> Co-authored-by: Tomas Langer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enso has decided to use Helidon 4.0.x to emulate
WebSocketon Graal.js. However we have problems to run our code on native image with GraalVM for JDK21. More info available - in short: there is a bug in GraalVM for JDK21 that prevents usage of virtual threads and Graal.js.The bug was fixed in newer versions of GraalVM, but backport is complicated and we don't have a workaround for the bug on the GraalVM side and we'd like to stick with JDK 21.
Documentation
We have experimentally verified that with small changes in Helidon code we can use
@Substitutemechanism of GraalVM native image to switch to platform threads. As we don't care about massive performance, but just want to get things work, it is a sufficient solution for us.Can you accept this little refactoring into next version of Helidon, please? Thank you very much.