Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Enso Terminal in a background thread #11149

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Sep 23, 2024

Pull Request Description

Fixes #8688 by starting a background thread to initialize whole JLine infrastructure when executed with --repl option..

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 23, 2024
@JaroslavTulach JaroslavTulach self-assigned this Sep 23, 2024
@JaroslavTulach
Copy link
Member Author

None of the startup scenarios is affected:

obrazek

All are in the expected delta. Expected - we don't measure startup with --repl and that's the only one affected by initializing Enso terminal in a background.

@JaroslavTulach JaroslavTulach merged commit c6d1857 into develop Sep 24, 2024
43 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/JLineBackgroundInit8688 branch September 24, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize JLine terminal asynchronously
2 participants