Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to upload file by drag and drop #8158

Closed
4 tasks done
Frizi opened this issue Oct 26, 2023 · 4 comments
Closed
4 tasks done

Add the ability to upload file by drag and drop #8158

Frizi opened this issue Oct 26, 2023 · 4 comments
Assignees
@vitvakatu
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints

Comments

@Frizi
Copy link
Contributor

Frizi commented Oct 26, 2023 •
edited by vitvakatu
Loading

Tasks
Preview Give feedback
  4. Handle uploading state by adding relevant client awareness flag #8182
    -gui d-intermediate p-medium
    vitvakatu
@Frizi Frizi converted this from a draft issue Oct 26, 2023
@Frizi Frizi added the -gui label Oct 26, 2023
@Frizi Frizi mentioned this issue Oct 26, 2023
Closed
@Frizi Frizi added p-medium Should be completed in the next few sprints d-intermediate Difficulty: some prior knowledge required labels Oct 26, 2023
@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Oct 30, 2023
@vitvakatu vitvakatu mentioned this issue Oct 31, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Oct 31, 2023
@vitvakatu
Preserve error code in the error message from RPC (#8191)
660f4b3 
Needed for #8158
@enso-bot
Copy link

enso-bot bot commented Oct 31, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-10-30):

Progress: Created PR for CB breadcrumbs, starting working on a new task – supporting file upload by dragging and dropping them onto the scene. A moderate amount of various calls. It should be finished by 2023-11-03.

Next Day: Next day I will be working on the same task. continue working on uploading.

@enso-bot
Copy link

enso-bot bot commented Oct 31, 2023

Ilya Bogdanov reports a new STANDUP for today (2023-10-31):

Progress: Implementing many parts needed for uploading, error handling, and writing the actual bytes. It should be finished by 2023-11-03.

Next Day: Next day I will be working on the same task. continue implementation.

@vitvakatu vitvakatu mentioned this issue Nov 1, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Nov 1, 2023
@vitvakatu
Avoid crash when new directory created in project root (#8199)
f37ec96 
While working on #8158, I noticed a crash when the `data` directory is created at the project root. Turns out it is the issue in the `ydoc-server`, which thinks every filesystem event is about files. Unfortunately, we don‘t have the needed info available, so we need to make the `file/info` request.
@enso-bot
Copy link

enso-bot bot commented Nov 1, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-11-01):

Progress: Implemented uploading, fixed the issue in the ydoc-server. Thinking about implementing uploading progress indication for users. It should be finished by 2023-11-03.

@vitvakatu vitvakatu mentioned this issue Nov 2, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Nov 2, 2023
@vitvakatu
Upload files by drag and drop (#8214)
fb3d65d 
The first part of #8158. No progress indication for the user implemented.


https://github.com/enso-org/enso/assets/6566674/2d8157d4-748f-4442-a9c3-a96ba0029056

# Important Notes
A few notable changes:
- A fix for `DataServer/writeBytes`
- Using `@noble/hashes` instead of `sha3` because the latter only works with node. I also tried using `js-sha3`, but it does not work well with Vite (see emn178/js-sha3#36)
- Fixed initialization of the ID map for new nodes. Also, all new nodes are prepended by four spaces to have proper indentation inside the `main` function.
- Fixed random pattern name generation because the previous approach sometimes produces identifiers starting with a number.
@vitvakatu
Copy link
Contributor

Closed in #8214

@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Nov 6, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Frizi @vitvakatu