Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload files by drag and drop #8214

Merged
merged 27 commits into from
Nov 2, 2023
Merged

Conversation

vitvakatu
Copy link
Contributor

Pull Request Description

The first part of #8158. No progress indication for the user implemented.

Kapture.2023-11-02.at.16.56.12.mp4

Important Notes

A few notable changes:

  • A fix for DataServer/writeBytes
  • Using @noble/hashes instead of sha3 because the latter only works with node. I also tried using js-sha3, but it does not work well with Vite (see Sveltekit + Vite unable to import function emn178/js-sha3#36)
  • Fixed initialization of the ID map for new nodes. Also, all new nodes are prepended by four spaces to have proper indentation inside the main function.
  • Fixed random pattern name generation because the previous approach sometimes produces identifiers starting with a number.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@vitvakatu vitvakatu added the -gui label Nov 2, 2023
@vitvakatu vitvakatu self-assigned this Nov 2, 2023
@vitvakatu vitvakatu requested a review from Frizi as a code owner November 2, 2023 13:10
@vitvakatu vitvakatu added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Nov 2, 2023
@mergify mergify bot merged commit fb3d65d into develop Nov 2, 2023
34 of 36 checks passed
@mergify mergify bot deleted the wip/vitvakatu/uploading-files branch November 2, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants