Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On desktop, drag and drop file on the scene should read it directly from its location. #6263

Closed
sylwiabr opened this issue Apr 13, 2023 · 5 comments · Fixed by #8490
Closed
Assignees
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request

Comments

@sylwiabr
Copy link
Member

Discord username

No response

How important is this feature to you?

2 – Somewhat important, but I can live without it

Describe the idea you'd like to see implemented.

Currently, while dragging and dropping the file on the scene the file is automatically copied to the data folder inside a project folder.

Instead of this on desktop we should:

  1. link the file by default and read it,
  2. when dragging and dropping with ctrl the file should be copied to a data folder in a project.

Is your feature request related to a problem?

No response

Screenshots, screencasts, mockups.

No response

Would you be willing to help us implement this feature?

No

@sylwiabr sylwiabr added x-new-feature Type: new feature request -gui triage labels Apr 13, 2023
@farmaazon farmaazon changed the title Drag and drop file on the scene should link it by default on desktop On desktop, drag and drop file on the scene should read it directly from its location. Apr 13, 2023
@farmaazon
Copy link
Contributor

Renamed a bit to avoid a confusion I had with the file links.

@vitvakatu vitvakatu added d-intermediate Difficulty: some prior knowledge required p-low Low priority and removed triage labels Apr 17, 2023
@vitvakatu
Copy link
Contributor

This is a task for the GUI team, but we probably need to split it further.

@sylwiabr sylwiabr added this to the Beta Release milestone Apr 17, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Apr 24, 2023
@jdunkerley jdunkerley removed this from the Beta Release milestone Aug 31, 2023
@jdunkerley jdunkerley added p-medium Should be completed in the next few sprints and removed p-low Low priority labels Aug 31, 2023
@jdunkerley jdunkerley added -gui and removed -gui labels Sep 11, 2023
@somebody1234
Copy link
Contributor

I'm assuming "On desktop" means on Electron when using the local backend. In that case, the dashboard already does something like this for adding projects, so it may be a useful reference:

const file = event.files.get(item.key)
if (file != null) {
rowState.setPresence(presence.Presence.inserting)
try {
if (backend.type === backendModule.BackendType.local) {
let id: string
if (
'backendApi' in window &&
// This non-standard property is defined in Electron.
'path' in file &&
typeof file.path === 'string'
) {
id = await window.backendApi.importProjectFromPath(file.path)

@Frizi
Copy link
Contributor

Frizi commented Oct 26, 2023

Added an issue for implementing the existing file drag and drop behavior in new gui #8158

Special handling of local paths in electron client is kept out of scope from that task, so this feature report still stands.

@farmaazon
Copy link
Contributor

Refinement note:

  • To have "local" uploads, we must check both if we're electron (as other browser may not share the full path with us) and running the local project.

@farmaazon farmaazon removed their assignment Dec 4, 2023
@somebody1234 somebody1234 self-assigned this Dec 6, 2023
@mergify mergify bot closed this as completed in #8490 Dec 7, 2023
mergify bot pushed a commit that referenced this issue Dec 7, 2023
- Closes #6263

# Important Notes
- Still needs to be tested on Windows and macOS
- Currently does not check whether <kbd>Ctrl</kbd> is pressed to forcibly upload the file
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Dec 7, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants