Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make consistent types reported by the runtime with the types in the Suggestions Database #6800

Closed
4e6 opened this issue May 22, 2023 · 11 comments · Fixed by #6867
Closed

Make consistent types reported by the runtime with the types in the Suggestions Database #6800

4e6 opened this issue May 22, 2023 · 11 comments · Fixed by #6867
Assignees
@4e6
Labels
-compiler -language-server p-high Should be completed in the next sprint
Milestone
Design Partners

Comments

@4e6
Copy link
Contributor

4e6 commented May 22, 2023 •
edited
Loading

related #6715

Runtime type representation report static types with the .type suffix. In contrast, the suggestions database has the is_static flag instead. This creates inconsistencies in the language server API.

TODO

  • Return "function schema" together with the method pointer. It should contain a list of function arguments.
@4e6 4e6 added p-high Should be completed in the next sprint -compiler -language-server labels May 22, 2023
@4e6 4e6 self-assigned this May 22, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board May 23, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone May 23, 2023
@enso-bot
Copy link

enso-bot bot commented May 24, 2023

Dmitry Bushev reports a new STANDUP for yesterday (2023-05-24):

Progress: Started working on the issue. Reproduced the issue with the dynamic dropdown. Investigated the method pointers returned by the calls to Text.trim and Text.from_bytes. Tried to remove the .type suffix from the engine method pointer response. It should be finished by 2023-05-26.

Next Day: Next day I will be working on the #6800 task. Continue working on the task

@farmaazon
Copy link
Contributor

farmaazon commented May 25, 2023 •
edited by unfurl-links bot
Loading

Given https://github.com/orgs/enso-org/discussions/6762#discussioncomment-5992601 is this task still valid?

GitHub
When I was discussion with @Frizi the issue #6715, we discovered several points about Language Server API to be discussed broader @4e6 @hubertp : What widgets needs to know The widgets need to know...

@4e6 4e6 changed the title Append .type suffix to static types in the Suggestions Database Make consistent types reported by the runtime with the types in the Suggestions Database May 25, 2023
@4e6
Copy link
Contributor Author

4e6 commented May 25, 2023

I updated the description.

@farmaazon
Copy link
Contributor

TODO section still mentions adding .type to the Suggestion Database.

@4e6
Copy link
Contributor Author

4e6 commented May 25, 2023

After the discussion with @Frizi, we decided that besides the method pointer, the IDE needs to know the list of arguments expected by the function.

I updated the task description

@enso-bot
Copy link

enso-bot bot commented May 25, 2023

Dmitry Bushev reports a new STANDUP for today (2023-05-25):

Progress: Continue working on the issue. Added a method call info with unapplied arguments in addition to the method pointer response. Started working on fixing the tests. It should be finished by 2023-05-26.

Next Day: Next day I will be working on the #6800 task. Continue working on the task

@4e6 4e6 mentioned this issue May 26, 2023
Merged
3 tasks
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to ⚙️ Design in Issues Board May 29, 2023
@enso-bot
Copy link

enso-bot bot commented May 29, 2023

Dmitry Bushev reports a new STANDUP for the provided date (2023-05-26):

Progress: Continue working on the issue. Added tests checking the applied arguments. Found an issue with the partially applied constructor. Started looking for a workaround. It should be finished by 2023-05-26.

Next Day: Next day I will be working on the #6800 task. Continue working on the task

@jdunkerley jdunkerley moved this from ⚙️ Design to 🔧 Implementation in Issues Board May 30, 2023
@enso-bot
Copy link

enso-bot bot commented May 30, 2023

Dmitry Bushev reports a new 🔴 DELAY for yesterday (2023-05-29):

Summary: There is 4 days delay in implementation of the Make consistent types reported by the runtime with the types in the Suggestions Database (#6800) task.
It will cause 2 days delay for the delivery of this weekly plan.

Delay Cause: Found an issue with how the atom constructors are created. Tried to fix it as a part of the current task but it was more complicated than I initially thought. Created a separate issue #6900 for it.

@enso-bot
Copy link

enso-bot bot commented May 30, 2023

Dmitry Bushev reports a new STANDUP for yesterday (2023-05-29):

Progress: Continue working on the issue. Found the cause of why the engine reports the incorrect method call for atom constructors. Tried to find a workaround, but it turned out to be more involved than I initially thought. It should be finished by 2023-05-30.

Next Day: Next day I will be working on the #6800 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented May 30, 2023

Dmitry Bushev reports a new STANDUP for today (2023-05-30):

Progress: Continue working on the issue. Reported an issue with the incorrect method pointer for atom constructors. Updated the language server API. Updated the GUI to support the new API. Tested the new API in IDE. Updated the PR. It should be finished by 2023-05-30.

Next Day: Next day I will be working on the #6800 task. Continue working on the task

@mergify mergify bot closed this as completed in #6867 May 31, 2023
mergify bot pushed a commit that referenced this issue May 31, 2023
@4e6
Consistent self types (#6867)
ed3f9b3 
close #6800

Update the `executionContext/expressionUpdates` notification and send the list of not applied arguments in addition to the method pointer.

# Important Notes
IDE is updated to support the new API.
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board May 31, 2023
@4e6
Copy link
Contributor Author

4e6 commented May 31, 2023

The #6903 should fix expression updates for partially applied constructors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4e6 4e6

Labels
-compiler -language-server p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Consistent self types enso-org/enso
3 participants
@4e6 @farmaazon @jdunkerley