Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide java_internal fields of constructors #6900

Closed
4e6 opened this issue May 30, 2023 · 5 comments · Fixed by #6968
Closed

Hide java_internal fields of constructors #6900

4e6 opened this issue May 30, 2023 · 5 comments · Fixed by #6968
Assignees
@4e6
Labels
-compiler -language-server x-new-feature Type: new feature request

Comments

@4e6
Copy link
Contributor

4e6 commented May 30, 2023

Find a way to hide java_internal atom field suggestions in the component browser.
@4e6 4e6 self-assigned this May 30, 2023
@enso-bot enso-bot bot mentioned this issue May 30, 2023
Closed
@enso-bot
Copy link

enso-bot bot commented Jun 5, 2023

Dmitry Bushev reports a new STANDUP for today (2023-06-05):

Progress: Started working on the issue. Spent some time fixing failing tests of the PR that adds the context_id to the execution context create request. Started working on excluding internal getters from the suggestions when building the database. It should be finished by 2023-06-07.

Next Day: Next day I will be working on the #6900 task. Continue working on the task

@JaroslavTulach
Copy link
Member

Isn't the usual pattern the following?

type Column
    Value java_internal

Then I believe that single type constructors like the Value java_internal are already hidden from the suggestion database.

@jdunkerley jdunkerley moved this from ❓New to 🔧 Implementation in Issues Board Jun 6, 2023
@4e6
Copy link
Contributor Author

4e6 commented Jun 6, 2023

Currently, constructors with a single argument are not shown in dropdowns. But they still exist in the suggestions database.

@4e6 4e6 mentioned this issue Jun 6, 2023
Merged
3 tasks
@enso-bot
Copy link

enso-bot bot commented Jun 6, 2023

Dmitry Bushev reports a new STANDUP for today (2023-06-06):

Progress: Started working on the issue. Spent some time addressing the review comments of the PR that adds the context_id to the execution context create request and merged that PR. Implemented filtering of the getter suggestions when building the database. Tested in IDE. Created the PR. It should be finished by 2023-06-07.

Next Day: Next day I will be working on the #6900 task. Continue working on the task

@JaroslavTulach
Copy link
Member

JaroslavTulach commented Jun 7, 2023 •
edited
Loading

Currently, constructors with a single argument are not shown in dropdowns.
But they still exist in the suggestions database.

Do they? I excluded them out in 0536eeb. The code still seems to be present in (another reincarnation).

constructors with a single argument are not shown in dropdowns.

After some investigation I wonder what do you mean by not shown? Originally I thought you were saying that they are "filtered out" by the IDE. Are you?

Probably not. The logic to filter out single constructors from buildResolvedUnionTypeName still seems to be there.

@mergify mergify bot closed this as completed in #6968 Jun 7, 2023
mergify bot pushed a commit that referenced this issue Jun 7, 2023
@4e6
Skip internal field getters when building suggestions (#6968)
0a4df4f 
close #6900

This is a follow-up to the discussion of the imports/exports meeting.

Right now we have no control over the visibility of atom constructor arguments. One way to hide them is a convention of filtering getters by an `internal` prefix or suffix.
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@4e6 4e6

Labels
-compiler -language-server x-new-feature Type: new feature request
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip internal field getters when building suggestions enso-org/enso
2 participants
@4e6 @JaroslavTulach