Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent self types #6867

Merged
merged 11 commits into from
May 31, 2023
Merged

Consistent self types #6867

merged 11 commits into from
May 31, 2023

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented May 26, 2023

Pull Request Description

close #6800

Update the executionContext/expressionUpdates notification and send the list of not applied arguments in addition to the method pointer.

Important Notes

IDE is updated to support the new API.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label May 26, 2023
@4e6 4e6 self-assigned this May 26, 2023
@4e6 4e6 marked this pull request as ready for review May 31, 2023 06:42
Copy link
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the Rust part, and it looks OK.

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label May 31, 2023
@mergify mergify bot merged commit ed3f9b3 into develop May 31, 2023
@mergify mergify bot deleted the wip/db/6800-consistent-self-type branch May 31, 2023 15:47
)
}

it should "send method pointer updates of partially applied constructors" in {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run this test to simulate bug reported as

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make consistent types reported by the runtime with the types in the Suggestions Database
4 participants