Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecutionService.execute is running in uncached (e.g. slow) mode #5782

Closed
JaroslavTulach opened this issue Mar 1, 2023 · 3 comments · Fixed by #5783
Closed

ExecutionService.execute is running in uncached (e.g. slow) mode #5782

JaroslavTulach opened this issue Mar 1, 2023 · 3 comments · Fixed by #5783
Assignees
@JaroslavTulach
Labels
--low-performance -compiler p-high Should be completed in the next sprint
Milestone
Design Partners

Comments

@JaroslavTulach
Copy link
Member

While investigating DetachVisualisationHandler request timeout I collected collapse.zip profiling data. Looks like 1.5s is spend when org.enso.interpreter.service.ExecutionService.execute() calls uncached com.oracle.truffle.api.interop.InteropLibraryGen$UncachedDispatch.execute():

Uncached Interop

The code has to be modified to call into Truffle at full speed - e.g. use cached nodes.
@JaroslavTulach JaroslavTulach added p-high Should be completed in the next sprint -compiler --low-performance labels Mar 1, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Mar 1, 2023
@JaroslavTulach JaroslavTulach mentioned this issue Mar 1, 2023
Closed
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Mar 1, 2023
@JaroslavTulach JaroslavTulach added this to the Design Partners milestone Mar 1, 2023
This was referenced Mar 1, 2023
Merged
Closed
@enso-bot
Copy link

enso-bot bot commented Mar 2, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-03-01):

Progress: - investigating request time out: #5745 (comment)

Next Day: Cache invalidations & request timeout

@enso-bot
Copy link

enso-bot bot commented Mar 2, 2023

Jaroslav Tulach reports a new STANDUP for today (2023-03-02):

Progress: - CI fighting

Next Day: Vacation on Friday.

@JaroslavTulach JaroslavTulach assigned 4e6 and JaroslavTulach and unassigned 4e6 Mar 3, 2023
@mergify mergify bot closed this as completed in #5783 Mar 3, 2023
mergify bot pushed a commit that referenced this issue Mar 3, 2023
@JaroslavTulach
Switch to Truffle PE mode before calling into Enso (#5783)
f64edd8 
Enter partial evaluation mode via `CallTarget.call` before invoking `InteropLibrary`. Fixes #5782.
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Mar 3, 2023
@enso-bot
Copy link

enso-bot bot commented Mar 4, 2023

Jaroslav Tulach reports a new STANDUP for yesterday (2023-03-03):

Progress: - got integrated: #5783

Next Day: Performance & stability

@JaroslavTulach JaroslavTulach mentioned this issue Apr 19, 2023
Merged
2 tasks
@hubertp hubertp mentioned this issue Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroslavTulach JaroslavTulach

Labels
--low-performance -compiler p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Switch to Truffle PE mode before calling into Enso enso-org/enso
2 participants
@4e6 @JaroslavTulach