Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11s in Text_Utils.split_on_lines - 30% #5784

Closed
JaroslavTulach opened this issue Mar 1, 2023 · 2 comments
Closed

11s in Text_Utils.split_on_lines - 30% #5784

JaroslavTulach opened this issue Mar 1, 2023 · 2 comments
Assignees
@jdunkerley
Labels
--low-performance -libs Libraries: New libraries to be implemented
Milestone
Beta Release

Comments

@JaroslavTulach
Copy link
Member

New sample provided by @farmaazon at #5745 (comment) shows similar issue as #5782, but also contains an interesting observation. A lot of time is spent in TextUtils.split_on_lines. Is that appropriate?

image
@JaroslavTulach JaroslavTulach added -libs Libraries: New libraries to be implemented --low-performance labels Mar 1, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Mar 1, 2023
@JaroslavTulach
Copy link
Member Author

The snapshot was taken by following engine profiling instructions.

@JaroslavTulach
Copy link
Member Author

One can also use VisualVM's Polyglot Sampler to get Enso level profiling. Start the JVM with the LS+engine, "Open" it in VisualVM. Switch to polyglot sampler tab. Start CPU sampling. Do the desired action in the IDE. Stop sampling.

obrazek

@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 7, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Mar 14, 2023
@jdunkerley jdunkerley moved this from 📤 Backlog to ❓New in Issues Board Mar 14, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 14, 2023
@jdunkerley jdunkerley closed this as not planned Won't fix, can't repro, duplicate, stale May 30, 2023
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdunkerley jdunkerley

Labels
--low-performance -libs Libraries: New libraries to be implemented
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

No branches or pull requests
3 participants
@radeusgd @jdunkerley @JaroslavTulach