Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report AbstractTruffleException as a Panic #5794

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Report AbstractTruffleException as a Panic #5794

merged 3 commits into from
Mar 6, 2023

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Mar 2, 2023 •
edited
Loading

Pull Request Description

Report AbstractTruffleException as a Panic. Fixes #5260.

Checklist

Please include the following checklist in your PR:

  • All code conforms to the
    Scala,
    Java,
    style guides.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed: Enso GUI was tested when built using BOTH
      ./run ide build and ./run ide watch.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Mar 2, 2023
@JaroslavTulach JaroslavTulach added this to the Design Partners milestone Mar 2, 2023
@JaroslavTulach JaroslavTulach requested a review from farmaazon March 2, 2023 12:11
@JaroslavTulach JaroslavTulach self-assigned this Mar 2, 2023
@JaroslavTulach
Copy link
Member Author

Now the

npe = Panic.throw NullPointerException.new

is reported by the IDE as
NPE

@enso-bot enso-bot bot mentioned this pull request Mar 2, 2023
Closed
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Mar 6, 2023
@mergify mergify bot merged commit 161ea45 into develop Mar 6, 2023
@mergify mergify bot deleted the wip/jtulach/Npe_5260 branch March 6, 2023 19:05
@enso-bot enso-bot bot mentioned this pull request Mar 7, 2023
Closed
@JaroslavTulach JaroslavTulach mentioned this pull request Mar 9, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@jdunkerley jdunkerley jdunkerley approved these changes

@4e6 4e6 4e6 approved these changes

@farmaazon farmaazon Awaiting requested review from farmaazon

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
Design Partners
Development

Successfully merging this pull request may close these issues.

Throwing an unhandled exception in Polyglot Java results in a null in the UI and no caught error message
4 participants
@JaroslavTulach @4e6 @jdunkerley @GregoryTravis