Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Editor Widget - Size should be persisted. #10861

Closed
Tracked by #10856 ...
farmaazon opened this issue Aug 21, 2024 · 5 comments · Fixed by #11435
Closed
Tracked by #10856 ...

Table Editor Widget - Size should be persisted. #10861

farmaazon opened this issue Aug 21, 2024 · 5 comments · Fixed by #11435
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Aug 21, 2024

Similarly as the component size.

@farmaazon farmaazon changed the title Table input width should stay the size of the column. Table Editor Widget size should be persisted. Aug 21, 2024
@farmaazon farmaazon added p-medium Should be completed in the next few sprints x-new-feature Type: new feature request -gui labels Aug 21, 2024
@farmaazon farmaazon added this to the 2024-09 Release milestone Aug 21, 2024
@farmaazon farmaazon added the d-easy Difficulty: little prior knowledge required label Aug 21, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Aug 21, 2024
@farmaazon
Copy link
Contributor Author

Refinement notes:

  • Keep it in the metadata of widget in its AST.

@farmaazon farmaazon self-assigned this Oct 23, 2024
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Oct 23, 2024
@enso-bot
Copy link

enso-bot bot commented Oct 25, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-10-24):

Progress: Thought a lot how to implement persistence in a possibly general way. Learning, how the typing for node's metadata works in AST It should be finished by 2024-10-28.

Next Day: Next day I will be working on the same task. Try to finish the feature.

@enso-bot
Copy link

enso-bot bot commented Oct 25, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-10-25):

Progress: Almost finished, but stumbled on actual persistence: I realized that the data cannot be safely typed, and rather every widget should implement its own way of parsing/validating the data. It should be finished by 2024-10-28.

Next Day: Next day I will be working on the same task. Finish implementation.

@enso-bot
Copy link

enso-bot bot commented Oct 28, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-10-28):

Progress: Finished refactoring mentioned yesterday. Discovered another missing part: the module update building (which in turn affects how the actually persisted metadata are stored). Implemented, but not tested. It should be finished by 2024-10-31.

Next Day: Next day I will be working on the same task. Tests and PR (hopefully)

@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Oct 29, 2024
@AdRiley AdRiley changed the title Table Editor Widget size should be persisted. Table Editor Widget - Size should be persisted. Oct 29, 2024
@enso-bot
Copy link

enso-bot bot commented Oct 29, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-10-29):

Progress: Tests, cleanups, and created a PR. Then helped Paweł with bazel. It should be finished by 2024-10-31.

Next Day: Next day I will be working on the #10864 task. Start the new task: limit size of the table created by widget input.

@mergify mergify bot closed this as completed in #11435 Oct 30, 2024
mergify bot pushed a commit that referenced this issue Oct 30, 2024
Fixes #10861

Every widget may set metadata on its AST. Because once widget picker will be implemented a single AST node may have many possible widgets, their settings are kept in a map keyed by their name/key.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Oct 30, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Status: 🗄️ Archived
Development

Successfully merging a pull request may close this issue.

2 participants