Design Review of Table Input

[jdunkerley]

Bugs / Small Things:

Bugs / Small Things:

Preview Give feedback

1. Reorder entries in Component Browser so Table.new is visible and rename it to Data.table_input #10860
   -libs +1
   
2. Table Editor Widget - Size should be persisted. #10861
   -gui d-easy p-medium x-new-feature +4
   
3. Moving in the grid with cursor moves the component in the graph editor too. - Do not propagate arrow events from Table Widget #10859
4. Table Editor widget: removing columns and rows #10758
   -gui d-intermediate p-medium x-new-feature +4
   
5. Table Editor widget: reordering columns and rows #10759
   -gui d-intermediate p-medium s-research-needed x-new-feature +5
   
6. Table Widget: Styling when editing the column is very hard to see what is selected and the caret position. #10862
   --bug -gui d-easy p-medium +4
   
7. Table Widget: An explicit plus to add a column #10863
   -gui d-easy p-medium +3
   
8. Table Editor Widget - Limit size to 256 items. #10864
   -gui d-easy p-medium x-new-feature +4
   
9. Table Editor Widget - Quick edit mode #10865
   -gui d-intermediate p-medium x-new-feature +4

Bigger Changes

• Type selector drop down shown where the indicator is in the table viz.
• Code should still be shown - with an indicator to edit in the visualization panel.
  • Would enable full screen
  • Also eventually might want to allow creating points on a map etc.
• Once reach a specified size (256 items?) then want to be serializing to a CSV file rather than too code.
  • Type can be serialized as a special character an end of column name.

[farmaazon]

❓How can libs control when to use Table Input?

ATM they cannot: the exact method call is hardcoded in https://github.com/enso-org/enso/blob/develop/app/gui2/src/components/GraphEditor/widgets/WidgetTableEditor.vue#L162

Shouldn't be able to drag out of the grid. Right click to delete a column?
Dragging column order should reorder columns in the code.

These are already tracked by #10758 and #10759

An explicit plus to add a column (and then default the name to Column where n is 1+ integer to be unique.

I guess this should replace the old way of adding column?

Limit size of table input to 256 items for now.

It is size of cells? So if I have a single column of 129 elements, am I forbidden to add new column while still able to add new row?

GitHub

enso/app/gui2/src/components/GraphEditor/widgets/WidgetTableEditor.vue at develop · enso-org/enso

Hybrid visual and textual functional programming. Contribute to enso-org/enso development by creating an account on GitHub.

[farmaazon]

Moving in the grid with cursor moves the component in the graph editor too.

Is this what we want to have? It would make selecting a range impossible.

[farmaazon]

Code should still be shown - with an indicator to edit in the visualization panel.

Even with the 256 limit, the code could be massive, making a very long node. So I would still hide most of the content, like

Table.new [['name', [...]], ['age', [...]], ['email', [...]], ...]

Or something like that.

As for editing in visualization: I'm not sure how it will play out with filtering/selecting columns - user might be confused that some operations are only in presentation (which may be then promoted to a new node), but others are affecting data.

[jdunkerley]

Moving in the grid with cursor moves the component in the graph editor too.

Is this what we want to have? It would make selecting a range impossible.

No this is a bug, the cursor keys should be captured by the grid and not sent to graph editor.

[jdunkerley]

Code should still be shown - with an indicator to edit in the visualization panel.

Even with the 256 limit, the code could be massive, making a very long node. So I would still hide most of the content, like

Table.new [['name', [...]], ['age', [...]], ['email', [...]], ...]

Or something like that.

As for editing in visualization: I'm not sure how it will play out with filtering/selecting columns - user might be confused that some operations are only in presentation (which may be then promoted to a new node), but others are affecting data.

Agree with this we would do something very much like this possibly replacing the whole Vector Table.new [ ... Edit In Vizualization ... ]

[farmaazon]

Moving in the grid with cursor moves the component in the graph editor too.

Is this what we want to have? It would make selecting a range impossible.

No this is a bug, the cursor keys should be captured by the grid and not sent to graph editor.

Fixed in #10859