Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Editor widget: removing columns and rows #10758

Closed
Tracked by #10856
farmaazon opened this issue Aug 6, 2024 · 5 comments · Fixed by #11151
Closed
Tracked by #10856

Table Editor widget: removing columns and rows #10758

farmaazon opened this issue Aug 6, 2024 · 5 comments · Fixed by #11151
Assignees
@farmaazon
Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Milestone
2024-09 Release

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Aug 6, 2024 •
edited
Loading

Follow up of #10293

The option for removing column/row should be in context menu, probably.

Also, the column should not be removable by dragging out.
@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request -gui labels Aug 6, 2024
@farmaazon farmaazon added this to the 2024-08 Release milestone Aug 6, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Aug 6, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Aug 6, 2024
@farmaazon
Copy link
Contributor Author

farmaazon commented Aug 8, 2024 •
edited by unfurl-links bot
Loading

Refinement notes:

The user can bring up the context menu by right clicking on a cell. By default, the context menu provides 'copy', 'paste' and 'export'. Copy will copy the selected cells or rows to the clipboard. Paste will always, forever, be disabled. Download AG Grid v32.1.0 today: The best Vue Table & Vue Data Grid in the world.

@farmaazon farmaazon mentioned this issue Aug 21, 2024
Open
@farmaazon farmaazon self-assigned this Sep 6, 2024
@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Sep 6, 2024
@enso-bot
Copy link

enso-bot bot commented Sep 6, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-09-06):

Progress: Implemented removing rows and added option to the cell menu It should be finished by 2024-09-13.

Next Day: Next day I will be working on the same task. Add removing columns, and then the menus for col/row headers.

@enso-bot
Copy link

enso-bot bot commented Sep 10, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-09-10):

Progress: Resumed work on removing rows and cols in table widget. Downgraded AGGrid version to avoid issues. Added remove column option, row index column and menus for them It should be finished by 2024-09-16.

Next Day: Next day I will be working on the same task. Code needs some cleanup. Remove/disable "remove" option for "virtual" row. change style of row index, then fix all tests.

@enso-bot
Copy link

enso-bot bot commented Sep 16, 2024

Adam Obuchowicz reports a new STANDUP for the provided date (2024-09-11):

Progress: Cleaned code and options, added tests. It should be finished by 2024-09-16.

Next Day: Next day I will be working on the same task. Mostly traveling - I'll see what I'll be able to do.

@enso-bot enso-bot bot mentioned this issue Sep 16, 2024
Closed
@farmaazon farmaazon mentioned this issue Sep 23, 2024
Merged
4 tasks
@mergify mergify bot closed this as completed in #11151 Sep 23, 2024
mergify bot pushed a commit that referenced this issue Sep 23, 2024
@farmaazon
Table Widget: removing columns and rows (#11151)
3941634 
Fixes: #10758

[Screencast from 2024-09-23 13-19-31.webm](https://github.com/user-attachments/assets/aa28708e-f4c9-400a-966d-1d82abe99f1e)

# Important Notes
To add custom options, I needed to bump AGGrid version. But not the newest one, as it made some bugs I failed to fix.
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Sep 23, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Sep 24, 2024
@enso-bot
Copy link

enso-bot bot commented Sep 26, 2024

Adam Obuchowicz reports a new STANDUP for the last Monday (2024-09-23):

Progress: Go back to removing rows and cols: made a separate style for row number, cleaned up and created a PR. It should be finished by 2024-09-23.

Next Day: Next day I will be working on the #11011 task. Planning + finishing last task from the iteration: autosized CB input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmaazon farmaazon

Labels
-gui d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints x-new-feature Type: new feature request
Projects
Issues Board
Status: 🗄️ Archived
Milestone
2024-09 Release
Development

Successfully merging a pull request may close this issue.

Table Widget: removing columns and rows enso-org/enso
1 participant
@farmaazon