Table Input Widget: Add column with plus #11388
Conversation
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
| // console.log(props.params.tooltipRegistry) | ||
| // provideTooltipRegistry._mock(props.params.tooltipRegistry) |
| if (inputElement.value == null) { | ||
| console.error('Tried to accept header new name without input element!') | ||
| console.warn('Tried to accept header new name without input element!') |
There was a problem hiding this comment.
Why not error--if this occurs we have a bug, right?
|
Adam Obuchowicz reports a new STANDUP for the last Tuesday (2024-10-22): Progress: Implemented the main feature, but still tests need to be updated. It should be finished by 2024-10-28. Next Day: Next day I will be working on the same task. Finish tests and create a PR |
|
Adam Obuchowicz reports a new STANDUP for the last Wednesday (2024-10-23): Progress: Finished tests and created a PR. Also created a PR with eslint bump and fixed flakiness of selection unit tests. It should be finished by 2024-10-28. Next Day: Next day I will be working on the #10861 task. address PR review and start implementing Widget's persistence. |
|
Adam Obuchowicz reports a new STANDUP for yesterday (2024-10-24): Progress: Addressed review and tried to fix tooltips in the "add column" icon. After all, found a workaround and added TODO to the code. It should be finished by 2024-10-25. |
farmaazon
added
the
CI: Clean build required
Pull Request Description
Fixes #10863
(The
Column #3in a screenshot below is just created and actually existing).Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,or the Snowflake database integration, a run of the Extra Tests has been scheduled.