-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove AliasAnalysis metadata from LocalScope #10833
Comments
A step towards 10% speedup seems possible, but:
|
Since #10837 the ./enso --log-level trace --run xyz.enso | grep "] Scope" I believe we are done. |
LocalScope is used in many places. It is referenced by some runtime objects, like
MethodRootNode
. The problem is thatLocalScope
contains references to AliasAnalysis metadata (e.g., AliasGraph in https://github.com/enso-org/enso/blob/develop/engine/runtime-compiler/src/main/scala/org/enso/compiler/context/LocalScope.scala#L34).Loading AliasAnalysis metadata in
IrToTruffle
is potentially very slow, as the size of the metadata is enormous. Therefore, we should avoid using AliasAnalysis metadata inIrToTruffle
altogether. This first PR (#10729) removed some usages and introduced new, lightweight,FramePointer
metadata. In this task, let's remove the references to AliasAnalysis metadata fromLocalScope
altogether.Tasks
Follow-up of #10129
The text was updated successfully, but these errors were encountered: