-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay loading of AliasAnalysis data #10837
Conversation
This ensure that one can see all the metadata on the IR.
# Conflicts: # engine/runtime-compiler/src/main/java/org/enso/compiler/pass/analyse/PassPersistance.java # engine/runtime-compiler/src/main/scala/org/enso/compiler/pass/analyse/alias/graph/Graph.scala
Also refactor NameResolutionAlgorithm to not use AliasMetadata
Test on Windows fails because of different length of new lines.
Running stdlibs benchmarks to verify impact on startup. There is 10% speedup of the most relevant benchmark! That's good, but not as good as one would hope for. Running:
one can still see more than 500 of |
Few functional changes were needed:
Another stdlibs benchmarks run to verify the state after recent changes. The 10% speedup still remains there: Marking ready to merge, if Pavel agrees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and small change. Great to see the stable 10% startup improvement. Let's merge this and continue with investigation of EnsoRootNode.buildFrameDescriptor()
as mentioned in #10837 (comment)
Pull Request Description
Continuation of #10729 and a step towards #10833 to actually speed things up by 10% by delaying loading of
AliasAnalysis
data.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,